sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart - Issue 344673002: Load instances of the same transformer from the same isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart

Issue 344673002: Load instances of the same transformer from the same isolate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/excluding_aggregate_transformer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart b/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart

index 14e5796083fa1766d7331bfe32045fe68b8d882c..9915a14bfd2d6e892cc31051ee95a9d8c2772150 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart

@@ -359,8 +359,8 @@ class AssetEnvironment {

// TODO(nweiz): if/when we support more built-in transformers, make

// this more general.

var containsDart2JS = graph.entrypoint.root.pubspec.transformers

- .any((transformers) => transformers

- .any((id) => id.package == '\$dart2js'));

+ .any((transformers) =>

+ transformers.any((config) => config.id.package == '\$dart2js'));

if (!containsDart2JS && useDart2JS) {

_builtInTransformers.addAll([