Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart

Issue 344673002: Load instances of the same transformer from the same isolate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart
deleted file mode 100644
index 50e754be0d346b81c6a1f6c170b729c600e5607f..0000000000000000000000000000000000000000
--- a/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart
+++ /dev/null
@@ -1,88 +0,0 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library pub.load_transformers;
-
-import 'dart:async';
-import 'dart:convert';
-import 'dart:isolate';
-
-import '../../../asset/dart/serialize.dart';
-import '../barback.dart';
-import '../dart.dart' as dart;
-import '../log.dart' as log;
-import '../utils.dart';
-import 'asset_environment.dart';
-import 'foreign_transformer.dart';
-import 'barback_server.dart';
-
-/// Load and return all transformers and groups from the libraries identified by
-/// [ids].
-///
-/// Returns a map from transformer ids to sets of transformer-like objects
-/// identified by these ids (these may be [Transformer]s,
-/// [AggregateTransformer]s, and/or [TransformerGroup]s).
-Future<Map<TransformerId, Set>> loadTransformers(AssetEnvironment environment,
- BarbackServer transformerServer, List<TransformerId> ids) {
- return mapFromIterableAsync(ids, value: (id) {
- return id.getAssetId(environment.barback);
- }).then((idsToAssetIds) {
- var baseUrl = transformerServer.url;
- var idsToUrls = mapMap(idsToAssetIds, value: (id, assetId) {
- var path = assetId.path.replaceFirst('lib/', '');
- // TODO(nweiz): load from a "package:" URI when issue 12474 is fixed.
- return baseUrl.resolve('packages/${id.package}/$path');
- });
-
- var code = new StringBuffer();
- code.writeln("import 'dart:isolate';");
-
- for (var url in idsToUrls.values) {
- code.writeln("import '$url';");
- }
-
- code.writeln("import r'$baseUrl/packages/\$pub/transformer_isolate.dart';");
- code.writeln(
- "void main(_, SendPort replyTo) => loadTransformers(replyTo);");
-
- log.fine("Loading transformers from $ids");
-
- var port = new ReceivePort();
- return dart.runInIsolate(code.toString(), port.sendPort)
- .then((_) => port.first)
- .then((sendPort) {
- return mapMapAsync(idsToAssetIds, value: (id, assetId) {
- return call(sendPort, {
- 'library': idsToUrls[id].toString(),
- 'mode': environment.mode.name,
- // TODO(nweiz): support non-JSON-encodable configuration maps.
- 'configuration': JSON.encode(id.configuration)
- }).then((transformers) {
- transformers = transformers.map(
- (transformer) => deserializeTransformerLike(transformer, id))
- .toSet();
- log.fine("Transformers from $assetId: $transformers");
- return transformers;
- });
- });
- }).catchError((error, stackTrace) {
- if (error is! CrossIsolateException) throw error;
- if (error.type != 'IsolateSpawnException') throw error;
-
- // TODO(nweiz): don't parse this as a string once issues 12617 and 12689
- // are fixed.
- var firstErrorLine = error.message.split('\n')[1];
- var missingTransformer = idsToUrls.keys.firstWhere((id) =>
- firstErrorLine.startsWith("Failure getting ${idsToUrls[id]}:"),
- orElse: () => throw error);
- var packageUri = idToPackageUri(idsToAssetIds[missingTransformer]);
-
- // If there was an IsolateSpawnException and the import that actually
- // failed was the one we were loading transformers from, throw an
- // application exception with a more user-friendly message.
- fail('Transformer library "$packageUri" not found.',
- error, stackTrace);
- });
- });
-}

Powered by Google App Engine
This is Rietveld 408576698