Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 344653004: Cleanup logic that generates about:gpu feature status. (Closed)

Created:
6 years, 6 months ago by Vangelis Kokkevis
Modified:
6 years, 6 months ago
Reviewers:
zmo, vangelis, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup logic that generates about:gpu feature status. Code cleanup for the logic that generates the labels used by the about:gpu page to report on the feature status. Also separates (and fixes) reporting for impl-side-painting and gpu rasterization. BUG=386420 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278541

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove gpu_switching and change Flash #

Total comments: 1

Patch Set 3 : Removed gpu switching labels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -71 lines) Patch
M content/browser/gpu/compositor_util.cc View 7 chunks +32 lines, -21 lines 0 comments Download
M content/browser/resources/gpu/info_view.js View 1 2 2 chunks +64 lines, -50 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vangelis
Mo, can you please take a look?
6 years, 6 months ago (2014-06-19 01:27:11 UTC) #1
Zhenyao Mo
LGTM https://codereview.chromium.org/344653004/diff/1/content/browser/resources/gpu/info_view.js File content/browser/resources/gpu/info_view.js (right): https://codereview.chromium.org/344653004/diff/1/content/browser/resources/gpu/info_view.js#newcode154 content/browser/resources/gpu/info_view.js:154: // GPU Switching Actually gpu switching is moved ...
6 years, 6 months ago (2014-06-19 01:42:45 UTC) #2
vangelis
On 2014/06/19 01:42:45, Zhenyao Mo wrote: > LGTM > > https://codereview.chromium.org/344653004/diff/1/content/browser/resources/gpu/info_view.js > File content/browser/resources/gpu/info_view.js (right): ...
6 years, 6 months ago (2014-06-19 02:10:31 UTC) #3
Zhenyao Mo
https://codereview.chromium.org/344653004/diff/20001/content/browser/resources/gpu/info_view.js File content/browser/resources/gpu/info_view.js (right): https://codereview.chromium.org/344653004/diff/20001/content/browser/resources/gpu/info_view.js#newcode152 content/browser/resources/gpu/info_view.js:152: // GPU Switching What I mean is, you can ...
6 years, 6 months ago (2014-06-19 16:52:01 UTC) #4
vangelis
On 2014/06/19 16:52:01, Zhenyao Mo wrote: > https://codereview.chromium.org/344653004/diff/20001/content/browser/resources/gpu/info_view.js > File content/browser/resources/gpu/info_view.js (right): > > https://codereview.chromium.org/344653004/diff/20001/content/browser/resources/gpu/info_view.js#newcode152 ...
6 years, 6 months ago (2014-06-19 16:59:11 UTC) #5
Zhenyao Mo
LGTM again. Thank you.
6 years, 6 months ago (2014-06-19 17:54:31 UTC) #6
vangelis
The CQ bit was checked by vangelis@google.com
6 years, 6 months ago (2014-06-19 18:21:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/344653004/40001
6 years, 6 months ago (2014-06-19 18:22:18 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 23:02:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 23:05:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85618)
6 years, 6 months ago (2014-06-19 23:05:51 UTC) #11
vangelis
The CQ bit was checked by vangelis@google.com
6 years, 6 months ago (2014-06-19 23:08:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/344653004/40001
6 years, 6 months ago (2014-06-19 23:10:37 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 00:09:02 UTC) #14
Message was sent while issue was closed.
Change committed as 278541

Powered by Google App Engine
This is Rietveld 408576698