Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 344623002: Fix installation of libgbm-dev package in install-build-deps.sh (Closed)

Created:
6 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Michael Moss, Torne
CC:
chromium-reviews, Torne, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix installation of libgbm-dev package in install-build-deps.sh crrev.com/106633002 has recently introduced a dependency on libgbm-dev. Unfortunatelly, this package is a bit more trickier to install, for the following reason: it depends on mesa-glx and, conversely to most of the other packages, only one version of mesa (w.r.t backports) can exist in the system. Google's workstations are configured to use the -lts-saucy version of mesa. The right package in this case is libgbm-dev-lts-saucy and attempting to install just libgbm-dev ends up in a failure. This change fixes install-build-deps.sh, installing the matching version of libgbm-dev (w.r.t libgl1-mesa-glx), falling back to libgbm-dev. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278433

Patch Set 1 #

Patch Set 2 : Rebase (after thakis@ birthday attacked me :P) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M build/install-build-deps.sh View 1 2 chunks +27 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Primiano Tucci (use gerrit)
See: [chromium-dev] Unmet dependencies when using install-build-deps.sh
6 years, 6 months ago (2014-06-18 18:32:50 UTC) #1
henrika (OOO until Aug 14)
FYI, there is a special version for android as well. Needs same fix?
6 years, 6 months ago (2014-06-18 18:55:55 UTC) #2
Primiano Tucci (use gerrit)
On 2014/06/18 18:55:55, henrika (OOO June 23-July 7) wrote: > FYI, there is a special ...
6 years, 6 months ago (2014-06-19 06:25:05 UTC) #3
henrika (OOO until Aug 14)
I tried it on my T530 and it worked for a while but then stopped ...
6 years, 6 months ago (2014-06-19 09:16:29 UTC) #4
Primiano Tucci (use gerrit)
On 2014/06/19 09:16:29, henrika (OOO June 23-July 7) wrote: > I tried it on my ...
6 years, 6 months ago (2014-06-19 12:53:41 UTC) #5
Primiano Tucci (use gerrit)
On 2014/06/19 09:16:29, henrika (OOO June 23-July 7) wrote: > I tried it on my ...
6 years, 6 months ago (2014-06-19 12:53:41 UTC) #6
hansmuller
I ran into this problem as well. Applying the patch (which has diverged a little) ...
6 years, 6 months ago (2014-06-19 17:19:14 UTC) #7
Torne
lgtm
6 years, 6 months ago (2014-06-19 17:21:43 UTC) #8
Primiano Tucci (use gerrit)
+thakis: no special reason, but he managed to land a change on the same file ...
6 years, 6 months ago (2014-06-19 17:41:01 UTC) #9
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 6 months ago (2014-06-19 17:41:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/344623002/20001
6 years, 6 months ago (2014-06-19 17:43:18 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 18:26:23 UTC) #12
Message was sent while issue was closed.
Change committed as 278433

Powered by Google App Engine
This is Rietveld 408576698