Record GCM received data message intervals in UMA

components/gcm_driver/gcm_stats_recorder_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/gcm_stats_recorder_impl.h"
 
 #include <deque>
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 
 namespace gcm {
 
 const uint32 MAX_LOGGED_ACTIVITY_COUNT = 100;
+const int64 RECEIVED_DATA_MESSAGE_BURST_LENGTH_SECONDS = 2;
 
 namespace {
 
 // Insert an item to the front of deque while maintaining the size of the deque.
 // Overflow item is discarded.
 template <typename T>
 T* InsertCircularBuffer(std::deque<T>* q, const T& item) {
   DCHECK(q);
   q->push_front(item);
   if (q->size() > MAX_LOGGED_ACTIVITY_COUNT) {
@@ skipping 326 matching lines @@
 }
 
 void GCMStatsRecorderImpl::RecordDataMessageReceived(
     const std::string& app_id,
     const std::string& from,
     int message_byte_size,
     bool to_registered_app,
     ReceivedMessageType message_type) {
   if (to_registered_app)
     UMA_HISTOGRAM_COUNTS("GCM.DataMessageReceived", 1);
+
+  base::Time new_timestamp = base::Time::Now();
+  if (last_received_data_message_burst_start_time_.is_null()) {
+    last_received_data_message_burst_start_time_ = new_timestamp;
+  } else if ((new_timestamp - last_received_data_message_burst_start_time_) >=
+             base::TimeDelta::FromSeconds(
+                 RECEIVED_DATA_MESSAGE_BURST_LENGTH_SECONDS)) {
+    UMA_HISTOGRAM_COUNTS(
+        "GCM.DataMessageBurstReceivedIntervalSeconds",
+        (new_timestamp - last_received_data_message_burst_start_time_)
+            .InSeconds());
+    last_received_data_message_burst_start_time_ = new_timestamp;
+  }
+
   if (!is_recording_)
     return;
   if (!to_registered_app) {
     RecordReceiving(app_id, from, message_byte_size, "Data msg received",
                     to_registered_app ? std::string() :

[Chirantan Ekbote, 2014/07/16 23:49:06]

This isn't a part of this patch but don't we already know that to_registered_app
is false here because of the if statement?  We shouldn't need to check it again.

                                         "No such registered app found");
   } else {
     switch(message_type) {
       case GCMStatsRecorderImpl::DATA_MESSAGE:
         RecordReceiving(app_id, from, message_byte_size, "Data msg received",
                         std::string());
         break;
       case GCMStatsRecorderImpl::DELETED_MESSAGES:
         RecordReceiving(app_id, from, message_byte_size, "Data msg received",
                         "Message has been deleted on server");
@@ skipping 80 matching lines @@
     const std::string& receiver_id,
     const std::string& message_id) {
   UMA_HISTOGRAM_COUNTS("GCM.IncomingSendErrors", 1);
   if (!is_recording_)
     return;
   RecordSending(app_id, receiver_id, message_id, "Received 'send error' msg",
                 std::string());
 }
 
 }  // namespace gcm