Record GCM received data message intervals in UMA

components/gcm_driver/gcm_stats_recorder_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/gcm_stats_recorder_impl.h"
 
 #include <deque>
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 
 namespace gcm {
 
 const uint32 MAX_LOGGED_ACTIVITY_COUNT = 100;
+const int64 RECEIVED_DATA_MESSAGE_BUSRT_SECONDS = 2;

[fgorski, 2014/07/16 04:11:11]

s/BUSRT/BURST/
s/BURST/BURST_LENGTH/

[juyik, 2014/07/16 17:49:23]

Done.

 
 namespace {
 
 // Insert an item to the front of deque while maintaining the size of the deque.
 // Overflow item is discarded.
 template <typename T>
 T* InsertCircularBuffer(std::deque<T>* q, const T& item) {
   DCHECK(q);
   q->push_front(item);
   if (q->size() > MAX_LOGGED_ACTIVITY_COUNT) {
@@ skipping 106 matching lines @@
     default:
       NOTREACHED();
       return "UNKNOWN_STATUS";
   }
 }
 
 }  // namespace
 
 GCMStatsRecorderImpl::GCMStatsRecorderImpl()
     : is_recording_(false),
-      delegate_(NULL) {
+      delegate_(NULL),
+      last_data_message_received_timestamp_(0) {
 }
 
 GCMStatsRecorderImpl::~GCMStatsRecorderImpl() {
 }
 
 void GCMStatsRecorderImpl::SetRecording(bool recording) {
   is_recording_ = recording;
 }
 
 void GCMStatsRecorderImpl::SetDelegate(Delegate* delegate) {
@@ skipping 199 matching lines @@
 }
 
 void GCMStatsRecorderImpl::RecordDataMessageReceived(
     const std::string& app_id,
     const std::string& from,
     int message_byte_size,
     bool to_registered_app,
     ReceivedMessageType message_type) {
   if (to_registered_app)
     UMA_HISTOGRAM_COUNTS("GCM.DataMessageReceived", 1);
+
+  int64 new_timestamp = base::Time::Now().ToTimeT();

[fgorski, 2014/07/16 04:11:11]

use base::Time

[juyik, 2014/07/16 17:49:23]

Done.

+  if (last_data_message_received_timestamp_ == 0) {
+    last_data_message_received_timestamp_ = new_timestamp;
+  } else if ((new_timestamp - last_data_message_received_timestamp_) >=

[fgorski, 2014/07/16 04:11:11]

new_timestamp - last_data_message_received_timestamp_ >
base::TimeDelta::FromSeconds(RECEIVED_DATA_MESSAGE_BURST_SECONDS)

[juyik, 2014/07/16 17:49:23]

Done.

+      RECEIVED_DATA_MESSAGE_BUSRT_SECONDS) {
+    UMA_HISTOGRAM_COUNTS("GCM.DataMessageBurstReceivedIntervalSeconds",
+                         new_timestamp - last_data_message_received_timestamp_);

[fgorski, 2014/07/16 04:11:11]

(new_timestamp - last_data_message_received_timestamp_).InSeconds()

[fgorski, 2014/07/16 04:32:24]

One more thing,
Remember to set last_data_message_received_timestamp_ = new_timestamp, as you
detected new burst.

[juyik, 2014/07/16 17:49:23]

Done.

[juyik, 2014/07/16 17:49:24]

Done.

+  }
+
   if (!is_recording_)
     return;
   if (!to_registered_app) {
     RecordReceiving(app_id, from, message_byte_size, "Data msg received",
                     to_registered_app ? std::string() :
                                         "No such registered app found");
   } else {
     switch(message_type) {
       case GCMStatsRecorderImpl::DATA_MESSAGE:
         RecordReceiving(app_id, from, message_byte_size, "Data msg received",
@@ skipping 85 matching lines @@
     const std::string& receiver_id,
     const std::string& message_id) {
   UMA_HISTOGRAM_COUNTS("GCM.IncomingSendErrors", 1);
   if (!is_recording_)
     return;
   RecordSending(app_id, receiver_id, message_id, "Received 'send error' msg",
                 std::string());
 }
 
 }  // namespace gcm