net/http/http_stream_factory_impl_job.cc - Issue 344603004: Avoid setting a duplicate SpdySessionKey on a Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 344603004: Avoid setting a duplicate SpdySessionKey on a Request (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index fbbe969c928c342b3c324b774cedff932460a3d1..79a95361d43f001ea33018d61eb1cb3f104e4c09 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -790,7 +790,8 @@ int HttpStreamFactoryImpl::Job::DoInitConnection() {

next_state_ = STATE_CREATE_STREAM;

existing_spdy_session_ = spdy_session;

return OK;

- } else if (request_ && (using_ssl_ || ShouldForceSpdyWithoutSSL())) {

+ } else if (request_ && !request_->HasSpdySessionKey() &&

+ (using_ssl_ || ShouldForceSpdyWithoutSSL())) {

// Update the spdy session key for the request that launched this job.

request_->SetSpdySessionKey(spdy_session_key);

}