Avoid setting a duplicate SpdySessionKey on a Request

Avoid setting a duplicate SpdySessionKey on a Request

BUG=364365
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278366

[Ryan Hamilton, 2014-06-18 19:04:45]

lgtm

https://codereview.chromium.org/344603004/diff/1/net/http/http_stream_factory...
File net/http/http_stream_factory_impl_request.cc (right):

https://codereview.chromium.org/344603004/diff/1/net/http/http_stream_factory...
net/http/http_stream_factory_impl_request.cc:57:
CHECK(!spdy_session_key_.get());
Is this DCHECK -> CHECK change temporary? If not, it seems like the style guide
would argue for a DCHECK here.  (Not that I'm a big fan of the style guide's
recommendations here.)

[Johnny, 2014-06-18 19:13:20]

https://codereview.chromium.org/344603004/diff/1/net/http/http_stream_factory...
File net/http/http_stream_factory_impl_request.cc (right):

https://codereview.chromium.org/344603004/diff/1/net/http/http_stream_factory...
net/http/http_stream_factory_impl_request.cc:57:
CHECK(!spdy_session_key_.get());
On 2014/06/18 19:04:45, Ryan Hamilton wrote:
> Is this DCHECK -> CHECK change temporary? If not, it seems like the style
guide
> would argue for a DCHECK here.  (Not that I'm a big fan of the style guide's
> recommendations here.)

Not temporary. Switched to CHECK because we'd rather crash than double-enter the
request into |spdy_session_request_map_|.

[Johnny, 2014-06-18 19:20:53]

The CQ bit was checked by jgraettinger@chromium.org

[commit-bot: I haz the power, 2014-06-18 19:22:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/344603004/1

[Johnny, 2014-06-18 22:27:31]

The CQ bit was unchecked by jgraettinger@chromium.org

[Johnny, 2014-06-19 03:38:00]

The CQ bit was checked by jgraettinger@chromium.org

[commit-bot: I haz the power, 2014-06-19 03:39:32]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/344603004/20001

[commit-bot: I haz the power, 2014-06-19 14:46:20]

Change committed as 278366