Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 344593002: Qualify RuntimeEnabledFeatures.h and remove unnecessary include dir. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, tzik, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, lushnikov+blink_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, falken, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, philipj_slow, timvolodine, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, nhiroki, alecflett+watch_chromium.org, michaeln, eustas+blink_chromium.org, serviceworker-reviews, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify RuntimeEnabledFeatures.h and remove unnecessary include dir. This CL removes the gen/blink/platform dir in core.gyp and qualifies all the instances that include RuntimeEnabledFeatures.h. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176440

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -64 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/IDBBindingUtilities.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomEventCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8ElementCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8ErrorEventCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8FileCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementFactory.cpp.tmpl View 2 chunks +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementTypeHelpers.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 2 chunks +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/EventFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StylePropertyShorthand.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/Init.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/battery/BatteryManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_light/DeviceLightController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketChannel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/FullscreenController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebKit.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebSocketImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/tests/PopupMenuTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
c.shu
6 years, 6 months ago (2014-06-18 15:07:40 UTC) #1
eseidel
lgtm I'd kinda rather these read "gen/platform/RuntimeEnabledFeatures.h" to reduce confusion as to where to look ...
6 years, 6 months ago (2014-06-18 15:30:34 UTC) #2
c.shu
On 2014/06/18 15:30:34, eseidel wrote: > lgtm > > I'd kinda rather these read "gen/platform/RuntimeEnabledFeatures.h" ...
6 years, 6 months ago (2014-06-18 15:33:47 UTC) #3
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-18 15:35:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/344593002/1
6 years, 6 months ago (2014-06-18 15:36:23 UTC) #5
haraken
LGTM
6 years, 6 months ago (2014-06-18 15:38:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 16:30:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11888)
6 years, 6 months ago (2014-06-18 16:30:50 UTC) #8
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-18 16:58:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/344593002/20001
6 years, 6 months ago (2014-06-18 16:59:59 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 18:19:00 UTC) #11
Message was sent while issue was closed.
Change committed as 176440

Powered by Google App Engine
This is Rietveld 408576698