Support LiveEdit on ARM

Support LiveEdit on ARM

BUG=368580
LOG=Y
R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21895

[alph, 2014-06-18 14:43:10]

Yang, could you please take a look.

[Yang, 2014-06-18 15:03:55]

https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc
File src/arm/debug-arm.cc (right):

https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc#newcode152
src/arm/debug-arm.cc:152: 
Are you sure this is correct? A brief comparison to the ia32 and x64 port shows
that this part is quite different. Can you explain where the frame is going to
be restored?

[alph, 2014-06-18 16:29:21]

https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc
File src/arm/debug-arm.cc (right):

https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc#newcode152
src/arm/debug-arm.cc:152: 
On 2014/06/18 15:03:55, Yang wrote:
> Are you sure this is correct? A brief comparison to the ia32 and x64 port
shows
> that this part is quite different. Can you explain where the frame is going to
> be restored?

FrameAndConstantPoolScope destructor is called here at the end of the block. It
makes a call to masm_->LeaveFrame(), see here:

https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/arm/macro-a...

which in turn restores sp from fp:

https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/arm/macro-a...

[Yang, 2014-06-19 12:28:40]

On 2014/06/18 16:29:21, alph wrote:
> https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc
> File src/arm/debug-arm.cc (right):
> 
>
https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc#newcode152
> src/arm/debug-arm.cc:152: 
> On 2014/06/18 15:03:55, Yang wrote:
> > Are you sure this is correct? A brief comparison to the ia32 and x64 port
> shows
> > that this part is quite different. Can you explain where the frame is going
to
> > be restored?
> 
> FrameAndConstantPoolScope destructor is called here at the end of the block.
It
> makes a call to masm_->LeaveFrame(), see here:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/arm/macro-a...
> 
> which in turn restores sp from fp:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/arm/macro-a...
Lgtm.

[alph, 2014-06-20 09:41:24]

Committed patchset #1 manually as r21895.