Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: test/same-source-file-name/gyptest-shared.py

Issue 344573002: Introduce '--no-duplicate-basename-check' option to disable the check of duplicate basenames (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Rebase with r1946 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/same-source-file-name/gyptest-fail-static.py ('k') | test/same-source-file-name/gyptest-static.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/same-source-file-name/gyptest-shared.py
diff --git a/test/same-source-file-name/gyptest-fail-shared.py b/test/same-source-file-name/gyptest-shared.py
similarity index 43%
rename from test/same-source-file-name/gyptest-fail-shared.py
rename to test/same-source-file-name/gyptest-shared.py
index 5b57826188238087deccdacfc118afcfb5234669..a57eb6159e492c7f8cc58481027eae82ad2b15c3 100755
--- a/test/same-source-file-name/gyptest-fail-shared.py
+++ b/test/same-source-file-name/gyptest-shared.py
@@ -9,10 +9,23 @@ Checks that gyp fails on shared_library targets which have several files with
the same basename.
"""
+import os
+
import TestGyp
test = TestGyp.TestGyp()
+# Fails by default for the compatibility with Visual C++ 2008 generator.
+# TODO: Update expected behavior when these legacy generators are deprecated.
test.run_gyp('double-shared.gyp', chdir='src', status=1, stderr=None)
+if ((test.format == 'msvs') and
+ (int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)):
+ test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
+ chdir='src', status=0, stderr=None)
+else:
+ test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
+ chdir='src')
+ test.build('double-shared.gyp', test.ALL, chdir='src')
+
test.pass_test()
« no previous file with comments | « test/same-source-file-name/gyptest-fail-static.py ('k') | test/same-source-file-name/gyptest-static.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698