chrome/browser/apps/ephemeral_app_service_factory.cc - Issue 344543006: Disable ephemeral apps after they stop running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_service_factory.cc

Issue 344543006: Disable ephemeral apps after they stop running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments and refactoring Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_service_factory.cc

diff --git a/chrome/browser/apps/ephemeral_app_service_factory.cc b/chrome/browser/apps/ephemeral_app_service_factory.cc

index 143c47daf8f3802c35afa861ad2518b8456509c4..18ecb086134660b9bae9d7759993884e4ce9fbe4 100644

--- a/chrome/browser/apps/ephemeral_app_service_factory.cc

+++ b/chrome/browser/apps/ephemeral_app_service_factory.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/apps/ephemeral_app_service_factory.h"

+#include "apps/app_lifetime_monitor_factory.h"

#include "chrome/browser/apps/ephemeral_app_service.h"

#include "chrome/browser/profiles/profile.h"

#include "components/keyed_service/content/browser_context_dependency_manager.h"

@@ -29,6 +30,7 @@ EphemeralAppServiceFactory::EphemeralAppServiceFactory()

"EphemeralAppService",

BrowserContextDependencyManager::GetInstance()) {

DependsOn(ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());

+ DependsOn(apps::AppLifetimeMonitorFactory::GetInstance());

}

EphemeralAppServiceFactory::~EphemeralAppServiceFactory() {