Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: extensions/browser/event_router.cc

Issue 344543006: Disable ephemeral apps after they stop running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prevent demotion of installed app due to race condition Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/event_router.cc
diff --git a/extensions/browser/event_router.cc b/extensions/browser/event_router.cc
index 3c6679fb997e45e2f4412eea8d9b84d8dcf3c63c..1fe776a9be9bea7e2b8a9cad3ef251f3cead2e7b 100644
--- a/extensions/browser/event_router.cc
+++ b/extensions/browser/event_router.cc
@@ -19,7 +19,6 @@
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
-#include "extensions/browser/extension_util.h"
#include "extensions/browser/extensions_browser_client.h"
#include "extensions/browser/lazy_background_task_queue.h"
#include "extensions/browser/process_manager.h"
@@ -572,15 +571,6 @@ bool EventRouter::MaybeLoadLazyBackgroundPageToDispatchEvent(
BrowserContext* context,
const Extension* extension,
const linked_ptr<Event>& event) {
- if (util::IsEphemeralApp(extension->id(), context) &&
- !event->can_load_ephemeral_apps) {
- // Most events can only be dispatched to ephemeral apps that are already
- // running.
- ProcessManager* pm = ExtensionSystem::Get(context)->process_manager();
- if (!pm->GetBackgroundHostForExtension(extension->id()))
- return false;
- }
-
if (!CanDispatchEventToBrowserContext(context, extension, event))
return false;
@@ -724,8 +714,7 @@ Event::Event(const std::string& event_name,
: event_name(event_name),
event_args(event_args.Pass()),
restrict_to_browser_context(NULL),
- user_gesture(EventRouter::USER_GESTURE_UNKNOWN),
- can_load_ephemeral_apps(false) {
+ user_gesture(EventRouter::USER_GESTURE_UNKNOWN) {
DCHECK(this->event_args.get());
}
@@ -735,8 +724,7 @@ Event::Event(const std::string& event_name,
: event_name(event_name),
event_args(event_args.Pass()),
restrict_to_browser_context(restrict_to_browser_context),
- user_gesture(EventRouter::USER_GESTURE_UNKNOWN),
- can_load_ephemeral_apps(false) {
+ user_gesture(EventRouter::USER_GESTURE_UNKNOWN) {
DCHECK(this->event_args.get());
}
@@ -751,8 +739,7 @@ Event::Event(const std::string& event_name,
restrict_to_browser_context(restrict_to_browser_context),
event_url(event_url),
user_gesture(user_gesture),
- filter_info(filter_info),
- can_load_ephemeral_apps(false) {
+ filter_info(filter_info) {
DCHECK(this->event_args.get());
}

Powered by Google App Engine
This is Rietveld 408576698