extensions/browser/api/app_runtime/app_runtime_api.cc - Issue 344543006: Disable ephemeral apps after they stop running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_runtime/app_runtime_api.cc

Issue 344543006: Disable ephemeral apps after they stop running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Prevent demotion of installed app due to race condition Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/app_runtime/app_runtime_api.cc

diff --git a/extensions/browser/api/app_runtime/app_runtime_api.cc b/extensions/browser/api/app_runtime/app_runtime_api.cc

index cb93a85c27227ae0ffdcc699949544f1da344a46..2e3ba3d9a870fee39987205d5c28716bb251266d 100644

--- a/extensions/browser/api/app_runtime/app_runtime_api.cc

+++ b/extensions/browser/api/app_runtime/app_runtime_api.cc

@@ -33,7 +33,6 @@ void DispatchOnLaunchedEventImpl(const std::string& extension_id,

scoped_ptr<Event> event(

new Event(app_runtime::OnLaunched::kEventName, args.Pass()));

event->restrict_to_browser_context = context;

- event->can_load_ephemeral_apps = true;

EventRouter::Get(context)

->DispatchEventWithLazyListener(extension_id, event.Pass());

ExtensionPrefs::Get(context)

@@ -58,7 +57,6 @@ void AppRuntimeEventRouter::DispatchOnRestartedEvent(

scoped_ptr<Event> event(

new Event(app_runtime::OnRestarted::kEventName, arguments.Pass()));

event->restrict_to_browser_context = context;

- event->can_load_ephemeral_apps = true;

EventRouter::Get(context)

->DispatchEventToExtension(extension->id(), event.Pass());

}