Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: chrome/browser/notifications/message_center_settings_controller.cc

Issue 344543006: Disable ephemeral apps after they stop running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments and refactoring Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/message_center_settings_controller.h" 5 #include "chrome/browser/notifications/message_center_settings_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/i18n/string_compare.h" 10 #include "base/i18n/string_compare.h"
11 #include "base/message_loop/message_loop_proxy.h" 11 #include "base/message_loop/message_loop_proxy.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "base/task/cancelable_task_tracker.h" 13 #include "base/task/cancelable_task_tracker.h"
14 #include "chrome/browser/browser_process.h" 14 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/chrome_notification_types.h" 15 #include "chrome/browser/chrome_notification_types.h"
16 #include "chrome/browser/content_settings/host_content_settings_map.h" 16 #include "chrome/browser/content_settings/host_content_settings_map.h"
17 #include "chrome/browser/extensions/app_icon_loader_impl.h" 17 #include "chrome/browser/extensions/app_icon_loader_impl.h"
18 #include "chrome/browser/extensions/extension_util.h"
19 #include "chrome/browser/favicon/favicon_service.h" 18 #include "chrome/browser/favicon/favicon_service.h"
20 #include "chrome/browser/favicon/favicon_service_factory.h" 19 #include "chrome/browser/favicon/favicon_service_factory.h"
21 #include "chrome/browser/history/history_types.h" 20 #include "chrome/browser/history/history_types.h"
22 #include "chrome/browser/notifications/desktop_notification_profile_util.h" 21 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
23 #include "chrome/browser/notifications/desktop_notification_service.h" 22 #include "chrome/browser/notifications/desktop_notification_service.h"
24 #include "chrome/browser/notifications/desktop_notification_service_factory.h" 23 #include "chrome/browser/notifications/desktop_notification_service_factory.h"
25 #include "chrome/browser/notifications/sync_notifier/chrome_notifier_service.h" 24 #include "chrome/browser/notifications/sync_notifier/chrome_notifier_service.h"
26 #include "chrome/browser/notifications/sync_notifier/chrome_notifier_service_fac tory.h" 25 #include "chrome/browser/notifications/sync_notifier/chrome_notifier_service_fac tory.h"
27 #include "chrome/browser/profiles/profile.h" 26 #include "chrome/browser/profiles/profile.h"
28 #include "chrome/browser/profiles/profile_info_cache.h" 27 #include "chrome/browser/profiles/profile_info_cache.h"
29 #include "chrome/browser/profiles/profile_manager.h" 28 #include "chrome/browser/profiles/profile_manager.h"
30 #include "chrome/common/extensions/api/notifications.h" 29 #include "chrome/common/extensions/api/notifications.h"
31 #include "chrome/common/extensions/extension_constants.h" 30 #include "chrome/common/extensions/extension_constants.h"
32 #include "components/favicon_base/favicon_types.h" 31 #include "components/favicon_base/favicon_types.h"
33 #include "content/public/browser/notification_service.h" 32 #include "content/public/browser/notification_service.h"
34 #include "content/public/browser/notification_source.h" 33 #include "content/public/browser/notification_source.h"
35 #include "extensions/browser/event_router.h" 34 #include "extensions/browser/event_router.h"
36 #include "extensions/browser/extension_registry.h" 35 #include "extensions/browser/extension_registry.h"
37 #include "extensions/browser/extension_util.h"
38 #include "extensions/common/constants.h" 36 #include "extensions/common/constants.h"
39 #include "extensions/common/extension.h" 37 #include "extensions/common/extension.h"
40 #include "extensions/common/permissions/permissions_data.h" 38 #include "extensions/common/permissions/permissions_data.h"
41 #include "grit/theme_resources.h" 39 #include "grit/theme_resources.h"
42 #include "grit/ui_strings.h" 40 #include "grit/ui_strings.h"
43 #include "ui/base/l10n/l10n_util.h" 41 #include "ui/base/l10n/l10n_util.h"
44 #include "ui/base/resource/resource_bundle.h" 42 #include "ui/base/resource/resource_bundle.h"
45 #include "ui/gfx/image/image.h" 43 #include "ui/gfx/image/image.h"
46 #include "ui/message_center/message_center_style.h" 44 #include "ui/message_center/message_center_style.h"
47 45
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 profile, extension_misc::EXTENSION_ICON_SMALL, this)); 225 profile, extension_misc::EXTENSION_ICON_SMALL, this));
228 for (extensions::ExtensionSet::const_iterator iter = extension_set.begin(); 226 for (extensions::ExtensionSet::const_iterator iter = extension_set.begin();
229 iter != extension_set.end(); 227 iter != extension_set.end();
230 ++iter) { 228 ++iter) {
231 const extensions::Extension* extension = iter->get(); 229 const extensions::Extension* extension = iter->get();
232 if (!extension->permissions_data()->HasAPIPermission( 230 if (!extension->permissions_data()->HasAPIPermission(
233 extensions::APIPermission::kNotifications)) { 231 extensions::APIPermission::kNotifications)) {
234 continue; 232 continue;
235 } 233 }
236 234
237 // Exclude cached ephemeral apps that are not currently running.
238 if (extensions::util::IsEphemeralApp(extension->id(), profile) &&
239 extensions::util::IsExtensionIdle(extension->id(), profile)) {
240 continue;
241 }
242
243 NotifierId notifier_id(NotifierId::APPLICATION, extension->id()); 235 NotifierId notifier_id(NotifierId::APPLICATION, extension->id());
244 notifiers->push_back(new Notifier( 236 notifiers->push_back(new Notifier(
245 notifier_id, 237 notifier_id,
246 base::UTF8ToUTF16(extension->name()), 238 base::UTF8ToUTF16(extension->name()),
247 notification_service->IsNotifierEnabled(notifier_id))); 239 notification_service->IsNotifierEnabled(notifier_id)));
248 app_icon_loader_->FetchImage(extension->id()); 240 app_icon_loader_->FetchImage(extension->id());
249 } 241 }
250 242
251 int app_count = notifiers->size(); 243 int app_count = notifiers->size();
252 244
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 // another creating a primary profile, and causes an infinite loop. 517 // another creating a primary profile, and causes an infinite loop.
526 // Thus, it would be better to delay creating group for guest login. 518 // Thus, it would be better to delay creating group for guest login.
527 base::MessageLoopProxy::current()->PostTask( 519 base::MessageLoopProxy::current()->PostTask(
528 FROM_HERE, 520 FROM_HERE,
529 base::Bind( 521 base::Bind(
530 &MessageCenterSettingsController::CreateNotifierGroupForGuestLogin, 522 &MessageCenterSettingsController::CreateNotifierGroupForGuestLogin,
531 weak_factory_.GetWeakPtr())); 523 weak_factory_.GetWeakPtr()));
532 } 524 }
533 #endif 525 #endif
534 } 526 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698