Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: extensions/browser/event_router.cc

Issue 344543006: Disable ephemeral apps after they stop running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prevent demotion of installed app due to race condition Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/event_router.h" 5 #include "extensions/browser/event_router.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
12 #include "base/stl_util.h" 12 #include "base/stl_util.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/browser/chrome_notification_types.h" 14 #include "chrome/browser/chrome_notification_types.h"
15 #include "content/public/browser/notification_service.h" 15 #include "content/public/browser/notification_service.h"
16 #include "content/public/browser/render_process_host.h" 16 #include "content/public/browser/render_process_host.h"
17 #include "extensions/browser/api_activity_monitor.h" 17 #include "extensions/browser/api_activity_monitor.h"
18 #include "extensions/browser/extension_host.h" 18 #include "extensions/browser/extension_host.h"
19 #include "extensions/browser/extension_prefs.h" 19 #include "extensions/browser/extension_prefs.h"
20 #include "extensions/browser/extension_registry.h" 20 #include "extensions/browser/extension_registry.h"
21 #include "extensions/browser/extension_system.h" 21 #include "extensions/browser/extension_system.h"
22 #include "extensions/browser/extension_util.h"
23 #include "extensions/browser/extensions_browser_client.h" 22 #include "extensions/browser/extensions_browser_client.h"
24 #include "extensions/browser/lazy_background_task_queue.h" 23 #include "extensions/browser/lazy_background_task_queue.h"
25 #include "extensions/browser/process_manager.h" 24 #include "extensions/browser/process_manager.h"
26 #include "extensions/browser/process_map.h" 25 #include "extensions/browser/process_map.h"
27 #include "extensions/common/extension.h" 26 #include "extensions/common/extension.h"
28 #include "extensions/common/extension_api.h" 27 #include "extensions/common/extension_api.h"
29 #include "extensions/common/extension_messages.h" 28 #include "extensions/common/extension_messages.h"
30 #include "extensions/common/extension_urls.h" 29 #include "extensions/common/extension_urls.h"
31 #include "extensions/common/manifest_handlers/background_info.h" 30 #include "extensions/common/manifest_handlers/background_info.h"
32 #include "extensions/common/manifest_handlers/incognito_info.h" 31 #include "extensions/common/manifest_handlers/incognito_info.h"
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 if (!cross_incognito) 564 if (!cross_incognito)
566 return true; 565 return true;
567 return ExtensionsBrowserClient::Get()->CanExtensionCrossIncognito( 566 return ExtensionsBrowserClient::Get()->CanExtensionCrossIncognito(
568 extension, context); 567 extension, context);
569 } 568 }
570 569
571 bool EventRouter::MaybeLoadLazyBackgroundPageToDispatchEvent( 570 bool EventRouter::MaybeLoadLazyBackgroundPageToDispatchEvent(
572 BrowserContext* context, 571 BrowserContext* context,
573 const Extension* extension, 572 const Extension* extension,
574 const linked_ptr<Event>& event) { 573 const linked_ptr<Event>& event) {
575 if (util::IsEphemeralApp(extension->id(), context) &&
576 !event->can_load_ephemeral_apps) {
577 // Most events can only be dispatched to ephemeral apps that are already
578 // running.
579 ProcessManager* pm = ExtensionSystem::Get(context)->process_manager();
580 if (!pm->GetBackgroundHostForExtension(extension->id()))
581 return false;
582 }
583
584 if (!CanDispatchEventToBrowserContext(context, extension, event)) 574 if (!CanDispatchEventToBrowserContext(context, extension, event))
585 return false; 575 return false;
586 576
587 LazyBackgroundTaskQueue* queue = ExtensionSystem::Get( 577 LazyBackgroundTaskQueue* queue = ExtensionSystem::Get(
588 context)->lazy_background_task_queue(); 578 context)->lazy_background_task_queue();
589 if (queue->ShouldEnqueueTask(context, extension)) { 579 if (queue->ShouldEnqueueTask(context, extension)) {
590 linked_ptr<Event> dispatched_event(event); 580 linked_ptr<Event> dispatched_event(event);
591 581
592 // If there's a dispatch callback, call it now (rather than dispatch time) 582 // If there's a dispatch callback, call it now (rather than dispatch time)
593 // to avoid lifetime issues. Use a separate copy of the event args, so they 583 // to avoid lifetime issues. Use a separate copy of the event args, so they
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 NOTREACHED(); 707 NOTREACHED();
718 return; 708 return;
719 } 709 }
720 } 710 }
721 711
722 Event::Event(const std::string& event_name, 712 Event::Event(const std::string& event_name,
723 scoped_ptr<base::ListValue> event_args) 713 scoped_ptr<base::ListValue> event_args)
724 : event_name(event_name), 714 : event_name(event_name),
725 event_args(event_args.Pass()), 715 event_args(event_args.Pass()),
726 restrict_to_browser_context(NULL), 716 restrict_to_browser_context(NULL),
727 user_gesture(EventRouter::USER_GESTURE_UNKNOWN), 717 user_gesture(EventRouter::USER_GESTURE_UNKNOWN) {
728 can_load_ephemeral_apps(false) {
729 DCHECK(this->event_args.get()); 718 DCHECK(this->event_args.get());
730 } 719 }
731 720
732 Event::Event(const std::string& event_name, 721 Event::Event(const std::string& event_name,
733 scoped_ptr<base::ListValue> event_args, 722 scoped_ptr<base::ListValue> event_args,
734 BrowserContext* restrict_to_browser_context) 723 BrowserContext* restrict_to_browser_context)
735 : event_name(event_name), 724 : event_name(event_name),
736 event_args(event_args.Pass()), 725 event_args(event_args.Pass()),
737 restrict_to_browser_context(restrict_to_browser_context), 726 restrict_to_browser_context(restrict_to_browser_context),
738 user_gesture(EventRouter::USER_GESTURE_UNKNOWN), 727 user_gesture(EventRouter::USER_GESTURE_UNKNOWN) {
739 can_load_ephemeral_apps(false) {
740 DCHECK(this->event_args.get()); 728 DCHECK(this->event_args.get());
741 } 729 }
742 730
743 Event::Event(const std::string& event_name, 731 Event::Event(const std::string& event_name,
744 scoped_ptr<ListValue> event_args, 732 scoped_ptr<ListValue> event_args,
745 BrowserContext* restrict_to_browser_context, 733 BrowserContext* restrict_to_browser_context,
746 const GURL& event_url, 734 const GURL& event_url,
747 EventRouter::UserGestureState user_gesture, 735 EventRouter::UserGestureState user_gesture,
748 const EventFilteringInfo& filter_info) 736 const EventFilteringInfo& filter_info)
749 : event_name(event_name), 737 : event_name(event_name),
750 event_args(event_args.Pass()), 738 event_args(event_args.Pass()),
751 restrict_to_browser_context(restrict_to_browser_context), 739 restrict_to_browser_context(restrict_to_browser_context),
752 event_url(event_url), 740 event_url(event_url),
753 user_gesture(user_gesture), 741 user_gesture(user_gesture),
754 filter_info(filter_info), 742 filter_info(filter_info) {
755 can_load_ephemeral_apps(false) {
756 DCHECK(this->event_args.get()); 743 DCHECK(this->event_args.get());
757 } 744 }
758 745
759 Event::~Event() {} 746 Event::~Event() {}
760 747
761 Event* Event::DeepCopy() { 748 Event* Event::DeepCopy() {
762 Event* copy = new Event(event_name, 749 Event* copy = new Event(event_name,
763 scoped_ptr<base::ListValue>(event_args->DeepCopy()), 750 scoped_ptr<base::ListValue>(event_args->DeepCopy()),
764 restrict_to_browser_context, 751 restrict_to_browser_context,
765 event_url, 752 event_url,
766 user_gesture, 753 user_gesture,
767 filter_info); 754 filter_info);
768 copy->will_dispatch_callback = will_dispatch_callback; 755 copy->will_dispatch_callback = will_dispatch_callback;
769 return copy; 756 return copy;
770 } 757 }
771 758
772 EventListenerInfo::EventListenerInfo(const std::string& event_name, 759 EventListenerInfo::EventListenerInfo(const std::string& event_name,
773 const std::string& extension_id, 760 const std::string& extension_id,
774 content::BrowserContext* browser_context) 761 content::BrowserContext* browser_context)
775 : event_name(event_name), 762 : event_name(event_name),
776 extension_id(extension_id), 763 extension_id(extension_id),
777 browser_context(browser_context) {} 764 browser_context(browser_context) {}
778 765
779 } // namespace extensions 766 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698