Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 344533006: [XHR] Rewrite layout test redirect-cross-origin-tripmine.html using Promises (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
yhirano
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

[XHR] Rewrite layout test redirect-cross-origin-tripmine.html using Promises Unnecessary delay is removed Use js-test.js instead of manual logging, asserts BUG=27569 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176484

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -74 lines) Patch
M LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html View 1 2 4 chunks +73 lines, -53 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt View 1 1 chunk +36 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-18 07:08:36 UTC) #1
yhirano
https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html File LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html (right): https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html#newcode62 LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:62: testFailed("req.send() should throw"); shouldThrow? https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html#newcode68 LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:68: ASYNC_TEST_CASES = [ ...
6 years, 6 months ago (2014-06-18 08:02:49 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html File LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html (right): https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html#newcode62 LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:62: testFailed("req.send() should throw"); On 2014/06/18 08:02:48, yhirano wrote: > ...
6 years, 6 months ago (2014-06-18 09:26:10 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/344533006/diff/20001/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html File LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html (right): https://codereview.chromium.org/344533006/diff/20001/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html#newcode114 LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:114: }).catch(function(e) changed per offline discussion
6 years, 6 months ago (2014-06-18 10:47:21 UTC) #4
yhirano
lgtm
6 years, 6 months ago (2014-06-18 11:18:02 UTC) #5
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-19 03:23:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/344533006/40001
6 years, 6 months ago (2014-06-19 03:24:57 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 04:31:54 UTC) #8
Message was sent while issue was closed.
Change committed as 176484

Powered by Google App Engine
This is Rietveld 408576698