[XHR] Rewrite layout test redirect-cross-origin-tripmine.html using Promises

[XHR] Rewrite layout test redirect-cross-origin-tripmine.html using Promises

Unnecessary delay is removed

Use js-test.js instead of manual logging, asserts

BUG=27569
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176484

[yhirano, 2014-06-18 08:02:49]

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
File LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
(right):

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:62:
testFailed("req.send() should throw");
shouldThrow?

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:68:
ASYNC_TEST_CASES = [
var is missing.

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:81:
SYNC_TEST_CASES = [
ditto

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:116:
}, function(e)
I think this rescue function should be added at another level from the sync test
execution, i.e. you can use promise.then(f).catch(rescue)  rather than
promise.then(f, rescue).
That way an exception thrown from f will be rescued.

[tyoshino (SeeGerritForStatus), 2014-06-18 09:26:10]

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
File LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
(right):

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:62:
testFailed("req.send() should throw");
On 2014/06/18 08:02:48, yhirano wrote:
> shouldThrow?

Done.

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:68:
ASYNC_TEST_CASES = [
On 2014/06/18 08:02:48, yhirano wrote:
> var is missing.

Done.

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:81:
SYNC_TEST_CASES = [
On 2014/06/18 08:02:48, yhirano wrote:
> ditto

Done.

https://codereview.chromium.org/344533006/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:116:
}, function(e)
On 2014/06/18 08:02:48, yhirano wrote:
> I think this rescue function should be added at another level from the sync
test
> execution, i.e. you can use promise.then(f).catch(rescue)  rather than
> promise.then(f, rescue).
> That way an exception thrown from f will be rescued.

Done.

[tyoshino (SeeGerritForStatus), 2014-06-18 10:47:21]

https://codereview.chromium.org/344533006/diff/20001/LayoutTests/http/tests/x...
File LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
(right):

https://codereview.chromium.org/344533006/diff/20001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html:114:
}).catch(function(e)
changed per offline discussion

[yhirano, 2014-06-18 11:18:02]

lgtm

[tyoshino (SeeGerritForStatus), 2014-06-19 03:23:28]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-06-19 03:24:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/344533006/40001

[commit-bot: I haz the power, 2014-06-19 04:31:54]

Change committed as 176484