Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 344513003: Cleanup nuisance DVLOG calls in safe_browsing_database.cc. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler
Modified:
6 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Cleanup nuisance DVLOG calls in safe_browsing_database.cc. If I've never used them, they must not be useful. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277987

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -37 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 17 chunks +12 lines, -37 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Scott Hess - ex-Googler
Was doing a cleanup on filename storage, and the DVLOGs annoyed me. https://codereview.chromium.org/344513003/diff/1/chrome/browser/safe_browsing/safe_browsing_database.cc File chrome/browser/safe_browsing/safe_browsing_database.cc ...
6 years, 6 months ago (2014-06-18 00:08:42 UTC) #1
mattm
lgtm
6 years, 6 months ago (2014-06-18 00:29:58 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 6 months ago (2014-06-18 02:25:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/344513003/1
6 years, 6 months ago (2014-06-18 02:26:56 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:34:45 UTC) #5
Message was sent while issue was closed.
Change committed as 277987

Powered by Google App Engine
This is Rietveld 408576698