Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 344513002: MSE: Reduce spurious discontinuities caused by partial append window start overlaps (Closed)

Created:
6 years, 6 months ago by wolenetz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis
Project:
chromium
Visibility:
Public.

Description

MSE: Reduce spurious discontinuities caused by partial append window start overlaps If a frame overlaps appendWindowStart, partial append window filtering is supported for the track, and the frame is appended to the track buffer, this change updates the track buffer's last frame duration with the frame's original duration instead of the possibly trimmed duration. If the trimmed duration were used, then the discontinuity detection logic could detect a discontinuity on the next frame for the track where there would otherwise not be a discontinuity. BUG=381114 R=acolwell@chromium.org TEST=FrameProcessorTest.PartialAppendWindowFilterNoDiscontinuity Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M media/filters/frame_processor.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wolenetz
acolwell@, PTAL @ PS1: I found no regression specific to this change on a release ...
6 years, 6 months ago (2014-06-18 00:04:27 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 6 months ago (2014-06-18 00:32:15 UTC) #2
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 6 months ago (2014-06-18 01:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/344513002/1
6 years, 6 months ago (2014-06-18 01:11:26 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 07:45:29 UTC) #5
Message was sent while issue was closed.
Change committed as 277976

Powered by Google App Engine
This is Rietveld 408576698