Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 344483003: Remove gen/blink/core from build files since all includes have been qualified. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove gen/blink/core from build files since all includes have been qualified. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176581

Patch Set 1 #

Patch Set 2 : rebaseline #

Patch Set 3 : fix builds #

Patch Set 4 : fix builds. #

Patch Set 5 : fix builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/build/scripts/name_macros.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/MakeNames.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/InitModules.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseResource.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
c.shu
6 years, 6 months ago (2014-06-19 19:55:23 UTC) #1
c.shu
On 2014/06/19 19:55:23, c.shu wrote: Hi, haraken, If you don't mind, I am putting you ...
6 years, 6 months ago (2014-06-19 21:20:30 UTC) #2
eseidel
lgtm
6 years, 6 months ago (2014-06-19 21:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/344483003/30001
6 years, 6 months ago (2014-06-19 21:22:07 UTC) #4
c.shu
The CQ bit was unchecked by c.shu@samsung.com
6 years, 6 months ago (2014-06-19 21:22:37 UTC) #5
c.shu
On 2014/06/19 21:22:37, c.shu wrote: > The CQ bit was unchecked by mailto:c.shu@samsung.com Thanks, Eric. ...
6 years, 6 months ago (2014-06-19 21:23:17 UTC) #6
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-19 21:40:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/344483003/50001
6 years, 6 months ago (2014-06-19 21:41:10 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-19 22:43:04 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 22:59:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/1017)
6 years, 6 months ago (2014-06-19 22:59:09 UTC) #11
haraken
LGTM
6 years, 6 months ago (2014-06-19 23:15:28 UTC) #12
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-20 00:19:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/344483003/70001
6 years, 6 months ago (2014-06-20 00:21:01 UTC) #14
Nils Barth (inactive)
LGTM, great work Chang!!
6 years, 6 months ago (2014-06-20 00:53:58 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-20 01:29:17 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 02:28:16 UTC) #17
Message was sent while issue was closed.
Change committed as 176581

Powered by Google App Engine
This is Rietveld 408576698