Docserver: separate models for apps and extensions

chrome/common/extensions/docs/server2/manifest_data_source.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from copy import deepcopy
 import json
 
 from data_source import DataSource
-from features_utility import Filtered
 from future import Future
 from manifest_features import ConvertDottedKeysToNested
+from platform_util import GetPlatforms, PluralToSingular
+
 
 def _ListifyAndSortDocs(features, app_name):
   '''Convert a |feautres| dictionary, and all 'children' dictionaries, into
   lists recursively. Sort lists first by 'level' then by name.
   '''
   def sort_key(item):
     '''Key function to sort items primarily by level (according to index into
     levels) then subsort by name.
     '''
     levels = ('required', 'recommended', 'only_one', 'optional')
@@ skipping 76 matching lines @@
     if features:
       features[-1]['is_last'] = True
 
   annotate('required', features)
   return features
 
 class ManifestDataSource(DataSource):
   '''Provides access to the properties in manifest features.
   '''
   def __init__(self, server_instance, _):
-    self._features_bundle = server_instance.features_bundle
+    self._platform_bundle = server_instance.platform_bundle
     self._object_store = server_instance.object_store_creator.Create(
         ManifestDataSource)
 
-  def _CreateManifestData(self):
-    future_manifest_features = self._features_bundle.GetManifestFeatures()
+  def _CreateManifestDataForPlatform(self, platform):
+    future_manifest_features = self._platform_bundle.GetFeaturesBundle(
+        platform).GetManifestFeatures()
     def resolve():
       manifest_features = future_manifest_features.Get()
-      def for_templates(manifest_features, platform):
-        return _AddLevelAnnotations(_ListifyAndSortDocs(
-            ConvertDottedKeysToNested(
-                deepcopy(Filtered(manifest_features, platform + 's'))),
-            app_name=platform.capitalize()))
-      return {
-        'apps': for_templates(manifest_features, 'app'),
-        'extensions': for_templates(manifest_features, 'extension')
-      }
+      return _AddLevelAnnotations(_ListifyAndSortDocs(
+          ConvertDottedKeysToNested(deepcopy(manifest_features)),
+          app_name=PluralToSingular(platform).capitalize()))
+    return Future(callback=resolve)
+
+  def _CreateManifestData(self):
+    manifest_data_futures = dict((p, self._CreateManifestDataForPlatform(p))
+                                 for p in GetPlatforms())
+    def resolve():
+      return dict((platform, future.Get())
+                  for platform, future in manifest_data_futures.iteritems())
     return Future(callback=resolve)
 
   def _GetCachedManifestData(self):
     data = self._object_store.Get('manifest_data').Get()
     if data is None:
       data = self._CreateManifestData().Get()
       self._object_store.Set('manifest_data', data)
     return data
 
   def Cron(self):
     return self._CreateManifestData()
 
   def get(self, key):
     return self._GetCachedManifestData().get(key)