Issue 344443011: Remove duplicate extensions API compiler template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344443011: Remove duplicate extensions API compiler template. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove duplicate extensions API compiler template. I accidentally wrote another version of this without remembering that it already existed in extensions/generated_extensions_api.gni. R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279206

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -192 lines)			Patch
D	build/json_schema.gni	View	1 chunk	+0 lines, -140 lines	0 comments	Download
M	build/json_schema_bundle_compile.gypi	View	1 chunk	+1 line, -2 lines	1 comment	Download
M	chrome/common/extensions/api/BUILD.gn	View	2 chunks	+32 lines, -50 lines	0 comments	Download

Total messages: 4 (0 generated)

Ken Rockot(use gerrit already)

Nice. LGTM. I will switch the other API targets over to using gypi_to_gn.py for their ...

6 years, 6 months ago (2014-06-23 20:35:35 UTC) #2

brettw

If there is only one or two files or the list is static, this isn't ...

6 years, 6 months ago (2014-06-23 22:31:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r279206.