Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344443009: Delete the controllers when ScreenManager is deleted (Closed)

Created:
6 years, 6 months ago by dnicoara
Modified:
6 years, 6 months ago
Reviewers:
spang
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Delete the controllers when ScreenManager is deleted BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/ozone/platform/dri/screen_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dnicoara
PTAL
6 years, 6 months ago (2014-06-18 15:22:54 UTC) #1
spang
lgtm
6 years, 6 months ago (2014-06-18 15:26:16 UTC) #2
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 6 months ago (2014-06-18 15:26:34 UTC) #3
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 6 months ago (2014-06-18 16:38:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/344443009/1
6 years, 6 months ago (2014-06-18 16:39:58 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 16:41:24 UTC) #6
Message was sent while issue was closed. 
Change committed as 278100

Powered by Google App Engine
This is Rietveld 408576698