Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: Source/devtools/front_end/timeline/TimelineEventOverview.js

Issue 344443007: Encapsulate implementation-specific timeline record handling in TimelineUIUtils (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineEventOverview.js
diff --git a/Source/devtools/front_end/timeline/TimelineEventOverview.js b/Source/devtools/front_end/timeline/TimelineEventOverview.js
index 891a0460ae9e73e0b7b998738d246b788631f0a2..1ad996560dbf26c18ae528e6152cdb9e73a3470b 100644
--- a/Source/devtools/front_end/timeline/TimelineEventOverview.js
+++ b/Source/devtools/front_end/timeline/TimelineEventOverview.js
@@ -32,11 +32,12 @@
* @constructor
* @extends {WebInspector.TimelineOverviewBase}
* @param {!WebInspector.TimelineModel} model
+ * @param {!WebInspector.TimelineUIUtils} uiUtils
*/
-WebInspector.TimelineEventOverview = function(model)
+WebInspector.TimelineEventOverview = function(model, uiUtils)
{
WebInspector.TimelineOverviewBase.call(this, model);
-
+ this._uiUtils = uiUtils;
this.element.id = "timeline-overview-events";
this._fillStyles = {};
@@ -87,7 +88,7 @@ WebInspector.TimelineEventOverview.prototype = {
*/
function appendRecord(record)
{
- if (record.type() === WebInspector.TimelineModel.RecordType.BeginFrame)
+ if (this._uiUtils.isBeginFrame(record))
return;
var recordStart = Math.floor((record.startTime() - timeOffset) * scale);
var recordEnd = Math.ceil((record.endTime() - timeOffset) * scale);

Powered by Google App Engine
This is Rietveld 408576698