Encapsulate implementation-specific timeline record handling in TimelineUIUtils

Source/devtools/front_end/timeline/TimelinePresentationModel.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 15 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  * @param {!WebInspector.TimelineModel} model
- * @param {!Object.<string, number>} coalescableRecordTypes
+ * @param {!WebInspector.TimelineUIUtils} uiUtils
  */
-WebInspector.TimelinePresentationModel = function(model, coalescableRecordTypes)
+WebInspector.TimelinePresentationModel = function(model, uiUtils)
 {
     this._model = model;
-    this._coalescableRecordTypes = coalescableRecordTypes;
+    this._uiUtils = uiUtils;
     this._filters = [];
     /**
      * @type {!Map.<!WebInspector.TimelineModel.Record, !WebInspector.TimelinePresentationModel.Record>}
      */
     this._recordToPresentationRecord = new Map();
     this.reset();
 }
 
 WebInspector.TimelinePresentationModel.prototype = {
     /**
@@ skipping 29 matching lines @@
         this._rootRecord = new WebInspector.TimelinePresentationModel.RootRecord();
         /** @type {!Object.<string, !WebInspector.TimelinePresentationModel.Record>} */
         this._coalescingBuckets = {};
     },
 
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      */
     addRecord: function(record)
     {
-        if (record.isProgram()) {
+        if (this._uiUtils.isProgram(record)) {
             var records = record.children();
             for (var i = 0; i < records.length; ++i)
                 this._innerAddRecord(this._rootRecord, records[i]);
         } else {
             this._innerAddRecord(this._rootRecord, record);
         }
     },
 
     /**
      * @param {!WebInspector.TimelinePresentationModel.Record} parentRecord
@@ skipping 36 matching lines @@
 
         var lastRecord = bucket ? this._coalescingBuckets[bucket] : newParent._presentationChildren.peekLast();
         if (lastRecord && lastRecord.coalesced())
             lastRecord = lastRecord._presentationChildren.peekLast();
         var startTime = record.startTime();
         var endTime = record.endTime();
         if (!lastRecord)
             return null;
         if (lastRecord.record().type() !== record.type())
             return null;
-        if (!this._coalescableRecordTypes[record.type()])
+        if (!this._uiUtils.isCoalescable(record.type()))
             return null;
         if (lastRecord.record().endTime() + coalescingThresholdMillis < startTime)
             return null;
         if (endTime + coalescingThresholdMillis < lastRecord.record().startTime())
             return null;
         if (lastRecord.presentationParent().coalesced())
             return lastRecord.presentationParent();
         return this._replaceWithCoalescedRecord(lastRecord);
     },
 
@@ skipping 439 matching lines @@
     /**
      * @return {boolean}
      */
     hasWarnings: function()
     {
         return false;
     },
 
     __proto__: WebInspector.TimelinePresentationModel.Record.prototype
 }