Encapsulate implementation-specific timeline record handling in TimelineUIUtils

Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 29 matching lines @@
 importScript("TimelinePresentationModel.js");
 importScript("TracingTimelineModel.js");
 importScript("TimelineFrameModel.js");
 importScript("TimelineEventOverview.js");
 importScript("TimelineFrameOverview.js");
 importScript("TimelineMemoryOverview.js");
 importScript("TimelinePowerGraph.js");
 importScript("TimelinePowerOverview.js");
 importScript("TimelineFlameChart.js");
 importScript("TimelineUIUtils.js");
+importScript("TimelineUIUtilsImpl.js");
 importScript("TimelineView.js");
 importScript("TimelineTracingView.js");
 importScript("TimelineLayersView.js");
 importScript("TracingModel.js");
 importScript("TracingTimelineUIUtils.js");
 importScript("TransformController.js");
 
 /**
  * @constructor
  * @extends {WebInspector.Panel}
@@ skipping 13 matching lines @@
     this._windowEndTime = Infinity;
 
     // Create model.
     if (WebInspector.experimentsSettings.timelineTracingMode.isEnabled() ||
         WebInspector.experimentsSettings.timelineOnTraceEvents.isEnabled()) {
         this._tracingModel = new WebInspector.TracingModel(WebInspector.targetManager.activeTarget());
         this._tracingModel.addEventListener(WebInspector.TracingModel.Events.BufferUsage, this._onTracingBufferUsage, this);
 
         this._tracingTimelineModel = new WebInspector.TracingTimelineModel(this._tracingModel);
         this._model = this._tracingTimelineModel;
+        this._uiUtils = new WebInspector.TracingTimelineUIUtils();
     } else {
         this._model = new WebInspector.TimelineModelImpl(WebInspector.timelineManager);
+        this._uiUtils = new WebInspector.TimelineUIUtilsImpl();
     }
 
     this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStarted, this._onRecordingStarted, this);
     this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStopped, this._onRecordingStopped, this);
     this._model.addEventListener(WebInspector.TimelineModel.Events.RecordsCleared, this._onRecordsCleared, this);
     this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingProgress, this._onRecordingProgress, this);
     this._model.addEventListener(WebInspector.TimelineModel.Events.RecordFilterChanged, this._refreshViews, this);
     this._model.addEventListener(WebInspector.TimelineModel.Events.RecordAdded, this._onRecordAdded, this);
 
     this._model.target().profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._onProfilingStateChanged, this);
@@ skipping 171 matching lines @@
             this._lazyFrameModel = frameModel;
         }
         return this._lazyFrameModel;
     },
 
     /**
      * @return {!WebInspector.TimelineView}
      */
     _timelineView: function()
     {
-        if (!this._lazyTimelineView) {
-            var coalescableRecordTypes = this._tracingTimelineModel ? WebInspector.TracingTimelineUIUtils.coalescableRecordTypes : WebInspector.TimelineUIUtils.coalescableRecordTypes;
-            this._lazyTimelineView = new WebInspector.TimelineView(this, this._model, coalescableRecordTypes);
-        }
+        if (!this._lazyTimelineView)
+            this._lazyTimelineView = new WebInspector.TimelineView(this, this._model, this._uiUtils);
         return this._lazyTimelineView;
     },
 
     /**
      * @return {!WebInspector.View}
      */
     _layersView: function()
     {
         if (this._lazyLayersView)
             return this._lazyLayersView;
@@ skipping 324 matching lines @@
     {
         this._stackView.detach();
 
         var isFrameMode = this._overviewModeSetting.get() === WebInspector.TimelinePanel.OverviewMode.Frames;
         this._removeAllModeViews();
         this._overviewControls = [];
 
         if (isFrameMode)
             this._overviewControls.push(new WebInspector.TimelineFrameOverview(this._model, this._frameModel()));
         else
-            this._overviewControls.push(new WebInspector.TimelineEventOverview(this._model));
+            this._overviewControls.push(new WebInspector.TimelineEventOverview(this._model, this._uiUtils));
 
         if (WebInspector.experimentsSettings.timelineFlameChart.isEnabled() && this._flameChartEnabledSetting.get()) {
             var tracingTimelineModel = WebInspector.experimentsSettings.timelineOnTraceEvents.isEnabled() ? this._tracingTimelineModel : null;
             this._addModeView(new WebInspector.TimelineFlameChart(this, this._model, tracingTimelineModel, this._frameModel()));
         } else {
             this._addModeView(this._timelineView());
         }
 
         if (this._captureMemorySetting.get()) {
             if (!isFrameMode)  // Frame mode skews time, don't render aux overviews.
-                this._overviewControls.push(new WebInspector.TimelineMemoryOverview(this._model));
-            this._addModeView(new WebInspector.MemoryCountersGraph(this, this._model));
+                this._overviewControls.push(new WebInspector.TimelineMemoryOverview(this._model, this._uiUtils));
+            this._addModeView(new WebInspector.MemoryCountersGraph(this, this._model, this._uiUtils));
         }
 
         if (this._capturePowerSetting && this._capturePowerSetting.get()) {
             if (!isFrameMode)  // Frame mode skews time, don't render aux overviews.
                 this._overviewControls.push(new WebInspector.TimelinePowerOverview(this._model));
             this._addModeView(new WebInspector.TimelinePowerGraph(this, this._model));
         }
 
         if (this._captureTracingSetting && this._captureTracingSetting.get())
             this._addModeView(new WebInspector.TimelineTracingView(this, this._tracingModel, this._model));
@@ skipping 809 matching lines @@
      * @param {!WebInspector.TimelineModel.Record} record
      * @return {boolean}
      */
     accept: function(record)
     {
         return !this._hiddenRecords[record.type()];
     },
 
     __proto__: WebInspector.TimelineModel.Filter.prototype
 }