Encapsulate implementation-specific timeline record handling in TimelineUIUtils

Source/devtools/front_end/timeline/TimelineEventOverview.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.TimelineOverviewBase}
  * @param {!WebInspector.TimelineModel} model
+ * @param {!WebInspector.TimelineUIUtils} uiUtils
  */
-WebInspector.TimelineEventOverview = function(model)
+WebInspector.TimelineEventOverview = function(model, uiUtils)
 {
     WebInspector.TimelineOverviewBase.call(this, model);
-
+    this._uiUtils = uiUtils;
     this.element.id = "timeline-overview-events";
 
     this._fillStyles = {};
     var categories = WebInspector.TimelineUIUtils.categories();
     for (var category in categories) {
         this._fillStyles[category] = WebInspector.TimelineUIUtils.createFillStyleForCategory(this._context, 0, WebInspector.TimelineEventOverview._stripGradientHeight, categories[category]);
         categories[category].addEventListener(WebInspector.TimelineCategory.Events.VisibilityChanged, this._onCategoryVisibilityChanged, this);
     }
 
     this._disabledCategoryFillStyle = WebInspector.TimelineUIUtils.createFillStyle(this._context, 0, WebInspector.TimelineEventOverview._stripGradientHeight,
@@ skipping 30 matching lines @@
         this._context.fillStyle = "rgba(0, 0, 0, 0.05)";
         for (var i = 1; i < WebInspector.TimelineEventOverview._numberOfStrips; i += 2)
             this._context.fillRect(0.5, i * stripHeight + 0.5, this._canvas.width, stripHeight);
 
         /**
          * @param {!WebInspector.TimelineModel.Record} record
          * @this {WebInspector.TimelineEventOverview}
          */
         function appendRecord(record)
         {
-            if (record.type() === WebInspector.TimelineModel.RecordType.BeginFrame)
+            if (this._uiUtils.isBeginFrame(record))
                 return;
             var recordStart = Math.floor((record.startTime() - timeOffset) * scale);
             var recordEnd = Math.ceil((record.endTime() - timeOffset) * scale);
             var category = record.category();
             if (category.overviewStripGroupIndex < 0)
                 return;
             var bar = lastBarByGroup[category.overviewStripGroupIndex];
             // This bar may be merged with previous -- so just adjust the previous bar.
             if (bar) {
                 // If record fits entirely into previous bar just absorb it ignoring the category match.
@@ skipping 44 matching lines @@
         this._context.moveTo(0, 0);
         this._context.lineTo(width, 0);
         this._context.moveTo(0, WebInspector.TimelineEventOverview._stripGradientHeight);
         this._context.lineTo(width, WebInspector.TimelineEventOverview._stripGradientHeight);
         this._context.stroke();
         this._context.restore();
     },
 
     __proto__: WebInspector.TimelineOverviewBase.prototype
 }