DevTools: Code fixes for the Closure compiler roll

Source/devtools/front_end/ui/UIUtils.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 16 matching lines @@
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @param {!Element} element
  * @param {?function(!MouseEvent): boolean} elementDragStart
  * @param {function(!MouseEvent)} elementDrag
  * @param {?function(!MouseEvent)} elementDragEnd
- * @param {!string} cursor
+ * @param {string} cursor
  * @param {?string=} hoverCursor
  */
 WebInspector.installDragHandle = function(element, elementDragStart, elementDrag, elementDragEnd, cursor, hoverCursor)
 {
     element.addEventListener("mousedown", WebInspector.elementDragStart.bind(WebInspector, elementDragStart, elementDrag, elementDragEnd, cursor), false);
     if (hoverCursor !== null)
         element.style.cursor = hoverCursor || cursor;
 }
 
 /**
@@ skipping 112 matching lines @@
             WebInspector.GlassPane.DefaultFocusedViewStack[0].focus();
         this.element.remove();
     }
 }
 
 /**
  * @type {!Array.<!WebInspector.View>}
  */
 WebInspector.GlassPane.DefaultFocusedViewStack = [];
 
-WebInspector.isBeingEdited = function(node)
+/**
+ * @param {?EventTarget=} target

[aandrey, 2014/06/17 20:58:37]

why EventTarget?

[apavlov, 2014/06/18 07:55:13]

Same thing, added a cast in ShortcutRegistry.js

+ * @return {boolean}
+ */
+WebInspector.isBeingEdited = function(target)
 {
+    if (!target)
+        return false;
+    var node = /** @type {!Node} */ (target);
     if (node.nodeType !== Node.ELEMENT_NODE)
         return false;
     var element = /** {!Element} */ (node);
     if (element.classList.contains("text-prompt") || element.nodeName === "INPUT" || element.nodeName === "TEXTAREA")
         return true;
 
     if (!WebInspector.__editingCount)
         return false;
 
     while (element) {
         if (element.__editing)
             return true;
         element = element.parentElement;
     }
     return false;
 }
 
+/**
+ * @param {!Element} element
+ * @param {boolean} value
+ * @return {boolean}
+ */
 WebInspector.markBeingEdited = function(element, value)
 {
     if (value) {
         if (element.__editing)
             return false;
         element.classList.add("being-edited");
         element.__editing = true;
         WebInspector.__editingCount = (WebInspector.__editingCount || 0) + 1;
     } else {
         if (!element.__editing)
@@ skipping 263 matching lines @@
     if (kilobytes < 1024)
         return WebInspector.UIString("%.0f\u2009KB", kilobytes);
 
     var megabytes = kilobytes / 1024;
     if (megabytes < 100)
         return WebInspector.UIString("%.1f\u2009MB", megabytes);
     else
         return WebInspector.UIString("%.0f\u2009MB", megabytes);
 }
 
+/**
+ * @param {number} num
+ * @return {string}
+ */
 Number.withThousandsSeparator = function(num)
 {
     var str = num + "";
     var re = /(\d+)(\d{3})/;
     while (str.match(re))
         str = str.replace(re, "$1\u2009$2"); // \u2009 is a thin space.
     return str;
 }
 
+/**
+ * @return {boolean}
+ */
 WebInspector.useLowerCaseMenuTitles = function()
 {
     return WebInspector.platform() === "windows";
 }
 
+/**
+ * @param {string} format
+ * @param {?Array.<string>} substitutions
+ * @param {!Object.<string, function(string, ...):*>} formatters
+ * @param {string} initialValue
+ * @param {function(string, string): ?} append
+ * @return {!{formattedResult: string, unusedSubstitutions: ?Array.<string>}};
+ */
 WebInspector.formatLocalized = function(format, substitutions, formatters, initialValue, append)
 {
     return String.format(WebInspector.UIString(format), substitutions, formatters, initialValue, append);
 }
 
+/**
+ * @return {string}
+ */
 WebInspector.openLinkExternallyLabel = function()
 {
     return WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Open link in new tab" : "Open Link in New Tab");
 }
 
+/**
+ * @return {string}
+ */
 WebInspector.copyLinkAddressLabel = function()
 {
     return WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Copy link address" : "Copy Link Address");
 }
 
 WebInspector.installPortStyles = function()
 {
     var platform = WebInspector.platform();
     document.body.classList.add("platform-" + platform);
     var flavor = WebInspector.platformFlavor();
     if (flavor)
         document.body.classList.add("platform-" + flavor);
     var port = WebInspector.port();
     document.body.classList.add("port-" + port);
 }
 
 WebInspector._windowFocused = function(event)
 {
     if (event.target.document.nodeType === Node.DOCUMENT_NODE)
         document.body.classList.remove("inactive");
 }
 
 WebInspector._windowBlurred = function(event)
 {
     if (event.target.document.nodeType === Node.DOCUMENT_NODE)
         document.body.classList.add("inactive");
 }
 
+/**
+ * @return {!Element}
+ */
 WebInspector.previousFocusElement = function()
 {
     return WebInspector._previousFocusElement;
 }
 
+/**
+ * @return {!Element}
+ */
 WebInspector.currentFocusElement = function()
 {
     return WebInspector._currentFocusElement;
 }
 
 WebInspector._focusChanged = function(event)
 {
     WebInspector.setCurrentFocusElement(event.target);
 }
 
@@ skipping 81 matching lines @@
 {
     if (WebInspector._themeStyleElement)
         WebInspector._themeStyleElement.textContent = "";
 }
 
 /**
  * @param {!Element} element
  * @param {number} offset
  * @param {number} length
  * @param {!Array.<!Object>=} domChanges
+ * @return {?Element}
  */
 WebInspector.highlightSearchResult = function(element, offset, length, domChanges)
 {
     var result = WebInspector.highlightSearchResults(element, [new WebInspector.SourceRange(offset, length)], domChanges);
     return result.length ? result[0] : null;
 }
 
 /**
  * @param {!Element} element
  * @param {!Array.<!WebInspector.SourceRange>} resultRanges
  * @param {!Array.<!Object>=} changes
+ * @return {!Array.<!Element>}
  */
 WebInspector.highlightSearchResults = function(element, resultRanges, changes)
 {
     return WebInspector.highlightRangesWithStyleClass(element, resultRanges, "highlighted-search-result", changes);
 }
 
 /**
  * @param {!Element} element
  * @param {string} className
  */
@@ skipping 213 matching lines @@
     window.addEventListener("focus", WebInspector._windowFocused, false);
     window.addEventListener("blur", WebInspector._windowBlurred, false);
     document.addEventListener("focus", WebInspector._focusChanged, true);
     document.addEventListener("blur", WebInspector._documentBlurred, true);
     window.removeEventListener("DOMContentLoaded", windowLoaded, false);
 }
 
 window.addEventListener("DOMContentLoaded", windowLoaded, false);
 
 })();