DevTools: Code fixes for the Closure compiler roll

Source/devtools/front_end/sdk/IndexedDBModel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 43 matching lines @@
     DateType:    "date",
     ArrayType:   "array"
 };
 
 WebInspector.IndexedDBModel.KeyPathTypes = {
     NullType:    "null",
     StringType:  "string",
     ArrayType:   "array"
 };
 
+/**
+ * @param {*} idbKey
+ * @return {?Object}
+ */
 WebInspector.IndexedDBModel.keyFromIDBKey = function(idbKey)
 {
     if (typeof(idbKey) === "undefined" || idbKey === null)
         return null;
 
     var key = {};
     switch (typeof(idbKey)) {
     case "number":
         key.number = idbKey;
         key.type = WebInspector.IndexedDBModel.KeyTypes.NumberType;
@@ skipping 12 matching lines @@
                 key.array.push(WebInspector.IndexedDBModel.keyFromIDBKey(idbKey[i]));
             key.type = WebInspector.IndexedDBModel.KeyTypes.ArrayType;
         }
         break;
     default:
         return null;
     }
     return key;
 }
 
+/**
+ * @param {?IDBKeyRange=} idbKeyRange
+ * @return {?{lower: ?Object, upper: ?Object, lowerOpen: *, upperOpen: *}}
+ */
 WebInspector.IndexedDBModel.keyRangeFromIDBKeyRange = function(idbKeyRange)
 {
-    var IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
     if (typeof(idbKeyRange) === "undefined" || idbKeyRange === null)

[aandrey, 2014/06/17 20:58:37]

typeof idbKeyRange

[apavlov, 2014/06/18 07:55:13]

Done.

         return null;
 
     var keyRange = {};
     keyRange.lower = WebInspector.IndexedDBModel.keyFromIDBKey(idbKeyRange.lower);
     keyRange.upper = WebInspector.IndexedDBModel.keyFromIDBKey(idbKeyRange.upper);
     keyRange.lowerOpen = idbKeyRange.lowerOpen;
     keyRange.upperOpen = idbKeyRange.upperOpen;
     return keyRange;
 }
 
 /**
  * @param {!IndexedDBAgent.KeyPath} keyPath
+ * @return {?string|!Array.<string>|undefined}
  */
 WebInspector.IndexedDBModel.idbKeyPathFromKeyPath = function(keyPath)
 {
     var idbKeyPath;
     switch (keyPath.type) {
     case WebInspector.IndexedDBModel.KeyPathTypes.NullType:
         idbKeyPath = null;
         break;
     case WebInspector.IndexedDBModel.KeyPathTypes.StringType:
         idbKeyPath = keyPath.string;
         break;
     case WebInspector.IndexedDBModel.KeyPathTypes.ArrayType:
         idbKeyPath = keyPath.array;
         break;
     }
     return idbKeyPath;
 }
 
+/**
+ * @param {?string|!Array.<string>|undefined} idbKeyPath
+ * @return {?string}
+ */
 WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath = function(idbKeyPath)
 {
     if (typeof idbKeyPath === "string")
         return "\"" + idbKeyPath + "\"";
     if (idbKeyPath instanceof Array)
         return "[\"" + idbKeyPath.join("\", \"") + "\"]";
     return null;
 }
 
 WebInspector.IndexedDBModel.EventTypes = {
@@ skipping 181 matching lines @@
 
             this.dispatchEventToListeners(WebInspector.IndexedDBModel.EventTypes.DatabaseLoaded, databaseModel);
         }
 
         this._agent.requestDatabase(databaseId.securityOrigin, databaseId.name, callback.bind(this));
     },
 
     /**
      * @param {!WebInspector.IndexedDBModel.DatabaseId} databaseId
      * @param {string} objectStoreName
-     * @param {webkitIDBKeyRange} idbKeyRange
+     * @param {?IDBKeyRange} idbKeyRange
      * @param {number} skipCount
      * @param {number} pageSize
      * @param {function(!Array.<!WebInspector.IndexedDBModel.Entry>, boolean)} callback
      */
     loadObjectStoreData: function(databaseId, objectStoreName, idbKeyRange, skipCount, pageSize, callback)
     {
         this._requestData(databaseId, databaseId.name, objectStoreName, "", idbKeyRange, skipCount, pageSize, callback);
     },
 
     /**
      * @param {!WebInspector.IndexedDBModel.DatabaseId} databaseId
      * @param {string} objectStoreName
      * @param {string} indexName
-     * @param {webkitIDBKeyRange} idbKeyRange
+     * @param {?IDBKeyRange} idbKeyRange
      * @param {number} skipCount
      * @param {number} pageSize
      * @param {function(!Array.<!WebInspector.IndexedDBModel.Entry>, boolean)} callback
      */
     loadIndexData: function(databaseId, objectStoreName, indexName, idbKeyRange, skipCount, pageSize, callback)
     {
         this._requestData(databaseId, databaseId.name, objectStoreName, indexName, idbKeyRange, skipCount, pageSize, callback);
     },
 
     /**
      * @param {!WebInspector.IndexedDBModel.DatabaseId} databaseId
      * @param {string} databaseName
      * @param {string} objectStoreName
      * @param {string} indexName
-     * @param {webkitIDBKeyRange} idbKeyRange
+     * @param {?IDBKeyRange} idbKeyRange
      * @param {number} skipCount
      * @param {number} pageSize
      * @param {function(!Array.<!WebInspector.IndexedDBModel.Entry>, boolean)} callback
      */
     _requestData: function(databaseId, databaseName, objectStoreName, indexName, idbKeyRange, skipCount, pageSize, callback)
     {
         /**
          * @param {?Protocol.Error} error
          * @param {!Array.<!IndexedDBAgent.DataEntry>} dataEntries
          * @param {boolean} hasMore
@@ skipping 114 matching lines @@
 
 WebInspector.IndexedDBModel.Index.prototype = {
     /**
      * @type {string}
      */
     get keyPathString()
     {
         return WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath(this.keyPath);
     }
 }