chrome/browser/extensions/tab_helper.h - Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.h

Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add note about what it means to revert RequestContentScript Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/content_rules_registry.cc ('K') | « chrome/browser/extensions/api/declarative_content/content_rules_registry.cc ('k') | chrome/browser/extensions/tab_helper.cc » ('j') | chrome/browser/extensions/tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/tab_helper.h

diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h

index 75fc21a4c1d3d0c96189289ddef3f4fc948dc241..b0ada6d464ed13585493075c7caf3599b708172a 100644

--- a/chrome/browser/extensions/tab_helper.h

+++ b/chrome/browser/extensions/tab_helper.h

@@ -206,7 +206,8 @@ class TabHelper : public content::WebContentsObserver,

const ScriptExecutionObserver::ExecutingScriptsMap& extension_ids,

int32 page_id,

const GURL& on_url);

- void OnWatchedPageChange(const std::vector<std::string>& css_selectors);

+ void OnWatchedPageChange(const std::string& event_name,

+ const std::vector<std::string>& css_selectors);

void OnDetailedConsoleMessageAdded(const base::string16& message,

const base::string16& source,

const StackTrace& stack_trace,