chrome/browser/extensions/api/declarative_content/content_constants.cc - Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_constants.cc

Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implement fixes from comments and add unit tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/content_action.cc ('K') | « chrome/browser/extensions/api/declarative_content/content_constants.h ('k') | chrome/common/extensions/api/declarative_content.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_constants.cc

diff --git a/chrome/browser/extensions/api/declarative_content/content_constants.cc b/chrome/browser/extensions/api/declarative_content/content_constants.cc

index dda4f93bcbb323dacd06f0573c21ca4d490cbf64..fe776a06b1c5d942260a4a34f69d658275aeca00 100644

--- a/chrome/browser/extensions/api/declarative_content/content_constants.cc

+++ b/chrome/browser/extensions/api/declarative_content/content_constants.cc

@@ -11,13 +11,17 @@ namespace declarative_content_constants {

const char kOnPageChanged[] = "declarativeContent.onPageChanged";

// Keys of dictionaries.

+const char kAllFrames[] = "allFrames";

const char kCss[] = "css";

const char kInstanceType[] = "instanceType";

+const char kJs[] = "js";

+const char kMatchAboutBlank[] = "matchAboutBlank";

const char kPageUrl[] = "pageUrl";

// Values of dictionaries, in particular instance types

const char kPageStateMatcherType[] = "declarativeContent.PageStateMatcher";

const char kShowPageAction[] = "declarativeContent.ShowPageAction";

+const char kRequestContentScript[] = "declarativeContent.RequestContentScript";

} // namespace declarative_content_constants

} // namespace extensions