extensions/common/extension_messages.h - Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_messages.h

Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Greatly simplified: Got rid of WatchedPagesRecipient and new event types Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/declarative_content.json ('K') | « chrome/renderer/resources/extensions/declarative_content_custom_bindings.js ('k') | extensions/renderer/content_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension_messages.h

diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h

index ffdf7760d05c391614a216d90cb4601a2a0957ba..f8cfbd469646930c8bd8ed940989ebb9bad6eede 100644

--- a/extensions/common/extension_messages.h

+++ b/extensions/common/extension_messages.h

@@ -453,7 +453,8 @@ IPC_MESSAGE_ROUTED0(ExtensionMsg_AppWindowClosed)

// searches match the active page. This message replaces the old set of

// searches, and triggers ExtensionHostMsg_OnWatchedPageChange messages from

// each tab to keep the browser updated about changes.

-IPC_MESSAGE_CONTROL1(ExtensionMsg_WatchPages,

+IPC_MESSAGE_CONTROL2(ExtensionMsg_WatchPages,

+ std::string, /* event_name */

std::vector<std::string> /* CSS selectors */)

// Send by the browser to indicate a Blob handle has been transferred to the

@@ -660,7 +661,8 @@ IPC_MESSAGE_CONTROL2(ExtensionHostMsg_AddDOMActionToActivityLog,

// main frame.

// * Something changed on an existing frame causing the set of matching searches

// to change.

-IPC_MESSAGE_ROUTED1(ExtensionHostMsg_OnWatchedPageChange,

+IPC_MESSAGE_ROUTED2(ExtensionHostMsg_OnWatchedPageChange,

+ std::string, /* event_name */

std::vector<std::string> /* Matching CSS selectors */)

// Sent by the renderer when it has received a Blob handle from the browser.