chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc - Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc

Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get rid of ContentScript Javascript type; only RequestContentScript is needed Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/content_rules_registry.cc ('k') | chrome/browser/extensions/tab_helper.h » ('j') | chrome/common/extensions/api/declarative_content.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc

index c55736b82086b08a1022552d18cef58fc8e4ea98..e489f2b3da080a4d2f645c746775321fab160fc9 100644

--- a/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc

@@ -7,6 +7,7 @@

#include <string>

#include "base/test/values_test_util.h"

+#include "chrome/browser/extensions/api/declarative_content/content_constants.h"

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/test_extension_environment.h"

#include "chrome/test/base/testing_profile.h"

@@ -34,11 +35,16 @@ class DeclarativeContentRulesRegistryTest : public testing::Test {

namespace {

+namespace constants = extensions::declarative_content_constants;

TEST_F(DeclarativeContentRulesRegistryTest, ActiveRulesDoesntGrow) {

TestExtensionEnvironment env;

scoped_refptr<ContentRulesRegistry> registry(

- new ContentRulesRegistry(env.profile(), NULL));

+ new ContentRulesRegistry(env.profile(),

+ constants::kOnPageChanged,

+ CONTENT_RULES_REGISTRY,

+ NULL));

EXPECT_EQ(0u, active_rules(*registry.get()).size());