extensions/common/watched_pages_recipient.h - Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/watched_pages_recipient.h

Issue 344433003: Prepare declarativeContent API for new script injection feature. Added Javascript types and functio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add description to new Javascript events Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef EXTENSIONS_COMMON_WATCHED_PAGES_RECIPIENT_H_

	6 #define EXTENSIONS_COMMON_WATCHED_PAGES_RECIPIENT_H_

	7

	8 namespace extensions {

	9

	10 enum WatchedPagesRecipient {

	11 CONTENT_RULES_REGISTRY = 0,
	Jeffrey Yasskin 2014/06/27 22:03:41 Definitely comment what these mean. If possible, t Definitely comment what these mean. If possible, though, it'd be nice to avoid the need for this enum. Mark Dittmer 2014/06/30 11:50:35 We could certainly change this to a boolean, but I Show quoted text On 2014/06/27 22:03:41, Jeffrey Yasskin wrote: > Definitely comment what these mean. If possible, though, it'd be nice to avoid > the need for this enum. We could certainly change this to a boolean, but I feel that there are two drawbacks to that change: 1. What do we name it? replyToBrowser captures the (non-)IPC'ness of the behavior, but obscures where the data is sent when there is no IPC. replyToScriptManagerOrRulesRegistry is already too verbose, and it doesn't even indicate which is true and which is false. I think your point that comments are needed here highlights why an enum is probably the right choice. 2. If we switch to a boolean and later end up routing data to a third component, we'll have to change the type in the message rather than simply augment it. If by your comment you mean that it would be nice to avoid sometimes sending to the browser process and sometimes not, I agree. Unfortunately, it doesn't look like we can achieve this (based on our recent email conversations about timely browser notification of page loads).
	12 USER_SCRIPT_MANAGER,

	13 WATCHED_PAGES_RECIPIENT_LAST = USER_SCRIPT_MANAGER,

	14 };

	15

	16 }

	17

	18 #endif // EXTENSIONS_COMMON_WATCHED_PAGES_RECIPIENT_H_

OLD	NEW

« chrome/common/extensions/api/declarative_content.json ('K') | « extensions/common/extension_messages.h ('k') | extensions/extensions.gyp » ('j') | no next file with comments »