Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: Source/bindings/v8/V8Callback.h

Issue 344423002: Remove useless function and typs in the V8Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/V8Callback.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef V8Callback_h 31 #ifndef V8Callback_h
32 #define V8Callback_h 32 #define V8Callback_h
33 33
34 #include "bindings/v8/ExceptionState.h"
35 #include "bindings/v8/V8Binding.h" 34 #include "bindings/v8/V8Binding.h"
36 #include "core/dom/ExceptionCode.h"
37 #include <v8.h> 35 #include <v8.h>
38 36
39 namespace WebCore { 37 namespace WebCore {
40 38
41 class ExecutionContext;
42
43 // Returns false if the callback threw an exception, true otherwise. 39 // Returns false if the callback threw an exception, true otherwise.
44 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, int argc, v8 ::Handle<v8::Value> argv[]); 40 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, int argc, v8 ::Handle<v8::Value> argv[]);
45 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v 8::Value> thisValue, int argc, v8::Handle<v8::Value> argv[]); 41 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v 8::Value> thisValue, int argc, v8::Handle<v8::Value> argv[]);
46 42
47 // FIXME: This file is used only by V8GeolocationCustom.cpp. Remove the custom b inding and this file.
48 enum CallbackAllowedValueFlag {
49 CallbackAllowUndefined = 1,
50 CallbackAllowNull = 1 << 1
51 };
52
53 typedef unsigned CallbackAllowedValueFlags;
54
55 // 'FunctionOnly' is assumed for the created callback.
56 template <typename V8CallbackType>
57 PassOwnPtr<V8CallbackType> createFunctionOnlyCallback(v8::Local<v8::Value> value , unsigned index, bool& succeeded, v8::Isolate* isolate, ExceptionState& excepti onState, CallbackAllowedValueFlags acceptedValues = 0)
58 {
59 succeeded = true;
60
61 if (value->IsUndefined() && (acceptedValues & CallbackAllowUndefined))
62 return nullptr;
63
64 if (value->IsNull() && (acceptedValues & CallbackAllowNull))
65 return nullptr;
66
67 if (!value->IsFunction()) {
68 succeeded = false;
69 exceptionState.throwDOMException(TypeMismatchError, ExceptionMessages::a rgumentNullOrIncorrectType(index, "Function"));
70 exceptionState.throwIfNeeded();
71 return nullptr;
72 }
73
74 return V8CallbackType::create(v8::Handle<v8::Function>::Cast(value), ScriptS tate::current(isolate));
75 }
76
77 } // namespace WebCore 43 } // namespace WebCore
78 44
79 #endif // V8Callback_h 45 #endif // V8Callback_h
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/V8Callback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698