Issue 344423002: Remove useless function and typs in the V8Callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344423002: Remove useless function and typs in the V8Callback (Closed)

Created:
6 years, 6 months ago by kihong

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove useless function and typs in the V8Callback CallbackAllowedValueFlags type and createFunctionOnlyCallback in the "V8Callback" class are not used. They have been only used for "V8GeolocationCustom.cpp", but that file was removed already. BUG=385426 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176726

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -35 lines)			Patch
	M	Source/bindings/v8/V8Callback.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download
	M	Source/bindings/v8/V8Callback.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM, this is a nice clean-up. Probably we can move invokeCallback in V8Callback.h to ActiveDOMCallback.h ...

6 years, 6 months ago (2014-06-23 06:13:59 UTC) #2

kihong

On 2014/06/23 06:13:59, haraken wrote: > LGTM, this is a nice clean-up. > > Probably ...

6 years, 6 months ago (2014-06-23 06:20:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/344423002/1

6 years, 6 months ago (2014-06-23 06:23:49 UTC) #5

Message was sent while issue was closed.

Change committed as 176726

Expand Messages | Collapse Messages