Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344273002: Enable checkjni for non-perf bots. (Closed)

Created:
6 years, 6 months ago by navabi
Modified:
6 years, 6 months ago
Reviewers:
bulach, tonyg, jbudorick, luqui
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable checkjni for non-perf bots. BUG=321755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279141

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make is_perf required param. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/android/provision_devices.py View 1 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
navabi
6 years, 6 months ago (2014-06-21 00:07:13 UTC) #1
tonyg
lgtm https://codereview.chromium.org/344273002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/344273002/diff/1/build/android/provision_devices.py#newcode75 build/android/provision_devices.py:75: def _ConfigureLocalProperties(device, is_perf=False): Let's just make the is_perf ...
6 years, 6 months ago (2014-06-21 00:28:04 UTC) #2
navabi
https://codereview.chromium.org/344273002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/344273002/diff/1/build/android/provision_devices.py#newcode75 build/android/provision_devices.py:75: def _ConfigureLocalProperties(device, is_perf=False): On 2014/06/21 00:28:04, tonyg wrote: > ...
6 years, 6 months ago (2014-06-21 01:05:07 UTC) #3
navabi
The CQ bit was checked by navabi@google.com
6 years, 6 months ago (2014-06-21 01:07:07 UTC) #4
jbudorick
lgtm
6 years, 6 months ago (2014-06-21 01:07:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/344273002/20001
6 years, 6 months ago (2014-06-21 01:09:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-21 07:11:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 08:08:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/20355)
6 years, 6 months ago (2014-06-21 08:08:14 UTC) #9
navabi
The CQ bit was checked by navabi@google.com
6 years, 6 months ago (2014-06-23 17:00:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/344273002/20001
6 years, 6 months ago (2014-06-23 17:01:54 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 18:15:11 UTC) #12
Message was sent while issue was closed. 
Change committed as 279141

Powered by Google App Engine
This is Rietveld 408576698