Stop using SpdySynReplyIR for SPDY 4.

net/spdy/spdy_proxy_client_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_proxy_client_socket.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/strings/utf_string_conversions.h"
 #include "net/base/address_list.h"
@@ skipping 54 matching lines @@
       public testing::WithParamInterface<NextProto> {
  public:
   SpdyProxyClientSocketTest();
 
   virtual void TearDown();
 
  protected:
   void Initialize(MockRead* reads, size_t reads_count, MockWrite* writes,
                   size_t writes_count);
   void PopulateConnectRequestIR(SpdySynStreamIR* syn_ir);
-  void PopulateConnectReplyIR(SpdySynReplyIR* reply_ir, const char* status);
+  void PopulateConnectReplyIR(SpdyHeaderBlock* block, const char* status);
   SpdyFrame* ConstructConnectRequestFrame();
   SpdyFrame* ConstructConnectAuthRequestFrame();
   SpdyFrame* ConstructConnectReplyFrame();
   SpdyFrame* ConstructConnectAuthReplyFrame();
   SpdyFrame* ConstructConnectRedirectReplyFrame();
   SpdyFrame* ConstructConnectErrorReplyFrame();
   SpdyFrame* ConstructBodyFrame(const char* data, int length);
   scoped_refptr<IOBufferWithSize> CreateBuffer(const char* data, int size);
   void AssertConnectSucceeds();
   void AssertConnectFails(int result);
@@ skipping 227 matching lines @@
 void SpdyProxyClientSocketTest::PopulateConnectRequestIR(
     SpdySynStreamIR* syn_ir) {
   spdy_util_.SetPriority(LOWEST, syn_ir);
   syn_ir->SetHeader(spdy_util_.GetMethodKey(), "CONNECT");
   syn_ir->SetHeader(spdy_util_.GetPathKey(), kOriginHostPort);
   syn_ir->SetHeader(spdy_util_.GetHostKey(), kOriginHost);
   syn_ir->SetHeader("user-agent", kUserAgent);
   spdy_util_.MaybeAddVersionHeader(syn_ir);
 }
 
-void SpdyProxyClientSocketTest::PopulateConnectReplyIR(SpdySynReplyIR* reply_ir,
+void SpdyProxyClientSocketTest::PopulateConnectReplyIR(SpdyHeaderBlock* block,
                                                        const char* status) {
-  reply_ir->SetHeader(spdy_util_.GetStatusKey(), status);
-  spdy_util_.MaybeAddVersionHeader(reply_ir);
+  (*block)[spdy_util_.GetStatusKey()] = status;
+  spdy_util_.MaybeAddVersionHeader(block);
 }
 
 // Constructs a standard SPDY SYN_STREAM frame for a CONNECT request.
 SpdyFrame*
 SpdyProxyClientSocketTest::ConstructConnectRequestFrame() {
   SpdySynStreamIR syn_ir(kStreamId);
   PopulateConnectRequestIR(&syn_ir);
   return spdy_util_.CreateFramer(false)->SerializeFrame(syn_ir);
 }
 
 // Constructs a SPDY SYN_STREAM frame for a CONNECT request which includes
 // Proxy-Authorization headers.
 SpdyFrame* SpdyProxyClientSocketTest::ConstructConnectAuthRequestFrame() {
   SpdySynStreamIR syn_ir(kStreamId);
   PopulateConnectRequestIR(&syn_ir);
   syn_ir.SetHeader("proxy-authorization", "Basic Zm9vOmJhcg==");
   return spdy_util_.CreateFramer(false)->SerializeFrame(syn_ir);
 }
 
 // Constructs a standard SPDY SYN_REPLY frame to match the SPDY CONNECT.
 SpdyFrame* SpdyProxyClientSocketTest::ConstructConnectReplyFrame() {
+  SpdyHeaderBlock block;
+  PopulateConnectReplyIR(&block, "200");
   SpdySynReplyIR reply_ir(kStreamId);
-  PopulateConnectReplyIR(&reply_ir, "200");
-  return spdy_util_.CreateFramer(false)->SerializeFrame(reply_ir);
+  return spdy_util_.ConstructSpdyReply(kStreamId, block);
 }
 
 // Constructs a standard SPDY SYN_REPLY frame to match the SPDY CONNECT,
 // including Proxy-Authenticate headers.
 SpdyFrame* SpdyProxyClientSocketTest::ConstructConnectAuthReplyFrame() {
-  SpdySynReplyIR reply_ir(kStreamId);
-  PopulateConnectReplyIR(&reply_ir, "407");
-  reply_ir.SetHeader("proxy-authenticate", "Basic realm=\"MyRealm1\"");
-  return framer_.SerializeFrame(reply_ir);
+  SpdyHeaderBlock block;
+  PopulateConnectReplyIR(&block, "407");
+  block["proxy-authenticate"] = "Basic realm=\"MyRealm1\"";
+  return spdy_util_.ConstructSpdyReply(kStreamId, block);
 }
 
 // Constructs a SPDY SYN_REPLY frame with an HTTP 302 redirect.
 SpdyFrame* SpdyProxyClientSocketTest::ConstructConnectRedirectReplyFrame() {
-  SpdySynReplyIR reply_ir(kStreamId);
-  PopulateConnectReplyIR(&reply_ir, "302");
-  reply_ir.SetHeader("location", kRedirectUrl);
-  reply_ir.SetHeader("set-cookie", "foo=bar");
-  return framer_.SerializeFrame(reply_ir);
+  SpdyHeaderBlock block;
+  PopulateConnectReplyIR(&block, "302");
+  block["location"] = kRedirectUrl;
+  block["set-cookie"] = "foo=bar";
+  return spdy_util_.ConstructSpdyReply(kStreamId, block);
 }
 
 // Constructs a SPDY SYN_REPLY frame with an HTTP 500 error.
 SpdyFrame* SpdyProxyClientSocketTest::ConstructConnectErrorReplyFrame() {
-  SpdySynReplyIR reply_ir(kStreamId);
-  PopulateConnectReplyIR(&reply_ir, "500");
-  return framer_.SerializeFrame(reply_ir);
+  SpdyHeaderBlock block;
+  PopulateConnectReplyIR(&block, "500");
+  return spdy_util_.ConstructSpdyReply(kStreamId, block);
 }
 
 SpdyFrame* SpdyProxyClientSocketTest::ConstructBodyFrame(
     const char* data,
     int length) {
   return framer_.CreateDataFrame(kStreamId, data, length, DATA_FLAG_NONE);
 }
 
 // ----------- Connect
 
@@ skipping 989 matching lines @@
 
   EXPECT_FALSE(sock_.get());
   EXPECT_TRUE(read_callback.have_result());
   EXPECT_FALSE(write_callback_.have_result());
 
   // Let the RST_STREAM write while |rst| is in-scope.
   base::MessageLoop::current()->RunUntilIdle();
 }
 
 }  // namespace net