Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 344253005: Use smart pointers to make SkPictureRecorder lifetimes less manual. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use smart pointers to make SkPictureRecorder lifetimes less manual. BUG=skia: R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/f22b6b5

Patch Set 1 #

Patch Set 2 : nl #

Patch Set 3 : record #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -36 lines) Patch
M include/core/SkPictureRecorder.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 2 4 chunks +17 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
6 years, 6 months ago (2014-06-23 15:59:53 UTC) #1
robertphillips
lgtm
6 years, 6 months ago (2014-06-23 17:25:46 UTC) #2
mtklein_C
6 years, 6 months ago (2014-06-23 17:29:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as rf22b6b5.

Powered by Google App Engine
This is Rietveld 408576698