Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 344253003: "interface" is defined in Windows headers, so undef it in GrGLCaps so we don't have a name collision (Closed)

Created:
6 years, 6 months ago by gw280
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

"interface" is defined in Windows headers, so undef it in GrGLCaps so we don't have a name collision R=bsalomon BUG=skia: Committed: https://skia.googlesource.com/skia/+/7c4c63a62e80b93df406abaa18dc4fcb47381fe6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't undef, rename instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGLCaps.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
gw280
6 years, 6 months ago (2014-06-20 18:45:51 UTC) #1
mtklein
https://codereview.chromium.org/344253003/diff/1/src/gpu/gl/GrGLCaps.h File src/gpu/gl/GrGLCaps.h (left): https://codereview.chromium.org/344253003/diff/1/src/gpu/gl/GrGLCaps.h#oldcode117 src/gpu/gl/GrGLCaps.h:117: bool init(const GrGLContextInfo& ctxInfo, const GrGLInterface* interface); Maybe you ...
6 years, 6 months ago (2014-06-20 18:48:17 UTC) #2
gw280
Either works for me. Brian - what would you prefer?
6 years, 6 months ago (2014-06-20 18:49:05 UTC) #3
bsalomon
On 2014/06/20 18:49:05, gw280 wrote: > Either works for me. Brian - what would you ...
6 years, 6 months ago (2014-06-24 13:27:22 UTC) #4
gw280
On 2014/06/24 13:27:22, bsalomon wrote: > I like Mike's idea of dropping the name. I ...
6 years, 6 months ago (2014-06-25 18:55:22 UTC) #5
bsalomon
lgtm
6 years, 6 months ago (2014-06-25 19:03:45 UTC) #6
gw280
The CQ bit was checked by george@mozilla.com
6 years, 6 months ago (2014-06-25 19:03:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/344253003/20001
6 years, 6 months ago (2014-06-25 19:04:14 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 19:14:34 UTC) #9
Message was sent while issue was closed.
Change committed as 7c4c63a62e80b93df406abaa18dc4fcb47381fe6

Powered by Google App Engine
This is Rietveld 408576698