Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 344253002: DirectWrite to not round already subpixel metrics. (Closed)

Created:
6 years, 6 months ago by bungeman-skia
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

DirectWrite to not round already subpixel metrics. In keeping with the FreeType and Mac scaler contexts, do not artificially round already subpixel metrics. The subpixel flag should be the 'forceSubpixel' flag when it comes to metrics. Existing backends will give subpixel metrics when 'subpixel' is requested, but will not round proper metrics when 'subpixel' is not requested. Committed: https://skia.googlesource.com/skia/+/a3530ef268acbbbd84cd4c5465cdc29df5269390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
This is the same as https://codereview.chromium.org/271673004/ , but at the time I had no way ...
6 years, 6 months ago (2014-06-20 17:12:43 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-06-20 17:14:24 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-20 17:19:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/344253002/1
6 years, 6 months ago (2014-06-20 17:20:26 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:35:04 UTC) #5
Message was sent while issue was closed.
Change committed as a3530ef268acbbbd84cd4c5465cdc29df5269390

Powered by Google App Engine
This is Rietveld 408576698