Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 344203006: Roll ANGLE DEPS for M37. (Closed)

Created:
6 years, 6 months ago by Jamie Madill
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Geoff Lang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE DEPS for M37. Includes several fixes for WebGL tests, large arrays in shaders, and regression on older nVidia drivers. BUG=384420, 380353, 379799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279179

Patch Set 1 #

Patch Set 2 : Fix android build #

Patch Set 3 : Update GN build #

Patch Set 4 : Fix commit_id scripts #

Patch Set 5 : Fix path to commit.h #

Patch Set 6 : Fix commit_id dependent settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -49 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/angle/BUILD.gn View 1 2 3 4 5 11 chunks +32 lines, -38 lines 0 comments Download
D build/secondary/third_party/angle/angle_commit.h View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jamie Madill
PTAL. Ken, if the bots are happy, should we manually commit or request merge for ...
6 years, 6 months ago (2014-06-20 19:07:09 UTC) #1
Ken Russell (switch to Gerrit)
On 2014/06/20 19:07:09, Jamie Madill wrote: > PTAL. Ken, if the bots are happy, should ...
6 years, 6 months ago (2014-06-20 19:16:05 UTC) #2
Jamie Madill
On 2014/06/20 19:16:05, Ken Russell wrote: > On 2014/06/20 19:07:09, Jamie Madill wrote: > > ...
6 years, 6 months ago (2014-06-20 19:19:57 UTC) #3
Shannon Woods
On 2014/06/20 19:19:57, Jamie Madill wrote: > On 2014/06/20 19:16:05, Ken Russell wrote: > > ...
6 years, 6 months ago (2014-06-20 19:31:07 UTC) #4
Jamie Madill
PTAL. We should look at moving the gn file into ANGLE at some point.
6 years, 6 months ago (2014-06-20 22:48:13 UTC) #5
Ken Russell (switch to Gerrit)
Nice work. LGTM
6 years, 6 months ago (2014-06-21 00:02:13 UTC) #6
Jamie Madill
On 2014/06/21 00:02:13, Ken Russell wrote: > Nice work. LGTM Thanks! @sky, could you also ...
6 years, 6 months ago (2014-06-23 17:17:10 UTC) #7
sky
LGTM
6 years, 6 months ago (2014-06-23 19:09:16 UTC) #8
Jamie Madill
The CQ bit was checked by jmadill@chromium.org
6 years, 6 months ago (2014-06-23 19:14:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmadill@chromium.org/344203006/100001
6 years, 6 months ago (2014-06-23 19:15:43 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 21:23:19 UTC) #11
Message was sent while issue was closed.
Change committed as 279179

Powered by Google App Engine
This is Rietveld 408576698