Issue 344203005: MIPS: Make object accessors more const-correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344203005: MIPS: Make object accessors more const-correct. (Closed)

Created:
6 years, 6 months ago by kilvadyb

Modified:
6 years, 6 months ago

Reviewers:
Sven Panne, Jakob Kummerow, Paul Lind, danno, kisg, palfia, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Make object accessors more const-correct. Port r21897 (1b152ae) Fix MIPS implementation of READ_DOUBLE_FIELD() to use const parameter. Original commit message: Getting closer to making our IsFOO and FOO::cast methods const-correct... BUG=

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/objects-inl.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kisg

LGTM , but we need someone from the Google team to approve. Could you please ...

6 years, 6 months ago (2014-06-20 17:05:17 UTC) #2

Committed as r21904.

Expand Messages | Collapse Messages