Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 344203003: Replace loadWithOverviewMode settings with calls to shrinksViewportContentToFit (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 19911983b5549fb078b1ef8486fc0f597816ff0e..98329e351874bbf5646070d6d2132252226a5afb 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -1049,7 +1049,7 @@ TEST_F(WebFrameTest, DelayedViewportInitialScale)
EXPECT_EQ(2, webViewHelper.webView()->pageScaleFactor());
}
-TEST_F(WebFrameTest, setLoadWithOverviewModeToFalse)
+TEST_F(WebFrameTest, setLoadWithoutShrinksViewportContentToFit)
{
UseMockScrollbarSettings mockScrollbarSettings;
registerMockedHttpURLLoad("viewport-auto-initial-scale.html");
@@ -1062,14 +1062,14 @@ TEST_F(WebFrameTest, setLoadWithOverviewModeToFalse)
FrameTestHelpers::WebViewHelper webViewHelper;
webViewHelper.initializeAndLoad(m_baseURL + "viewport-auto-initial-scale.html", true, 0, &client, enableViewportSettings);
webViewHelper.webView()->settings()->setWideViewportQuirkEnabled(true);
- webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);
+ webViewHelper.webView()->settings()->setShrinksViewportContentToFit(false);
webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
// The page must be displayed at 100% zoom.
EXPECT_EQ(1.0f, webViewHelper.webView()->pageScaleFactor());
}
-TEST_F(WebFrameTest, SetLoadWithOverviewModeToFalseAndNoWideViewport)
+TEST_F(WebFrameTest, SetLoadWithoutShrinksViewportContentToFitAndNoWideViewport)
{
UseMockScrollbarSettings mockScrollbarSettings;
registerMockedHttpURLLoad("large-div.html");
@@ -1081,7 +1081,7 @@ TEST_F(WebFrameTest, SetLoadWithOverviewModeToFalseAndNoWideViewport)
FrameTestHelpers::WebViewHelper webViewHelper;
webViewHelper.initializeAndLoad(m_baseURL + "large-div.html", true, 0, &client, enableViewportSettings);
- webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);
+ webViewHelper.webView()->settings()->setShrinksViewportContentToFit(false);
webViewHelper.webView()->settings()->setWideViewportQuirkEnabled(true);
webViewHelper.webView()->settings()->setUseWideViewport(false);
webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
@@ -1194,7 +1194,7 @@ TEST_F(WebFrameTest, WideViewportSetsTo980WithAutoWidth)
EXPECT_EQ(980.0 / viewportWidth * viewportHeight, webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->contentsSize().height());
}
-TEST_F(WebFrameTest, PageViewportInitialScaleOverridesLoadWithOverviewMode)
+TEST_F(WebFrameTest, PageViewportInitialScaleOverridesShrinksViewportContentToFit)
{
UseMockScrollbarSettings mockScrollbarSettings;
registerMockedHttpURLLoad("viewport-wide-2x-initial-scale.html");
@@ -1206,7 +1206,7 @@ TEST_F(WebFrameTest, PageViewportInitialScaleOverridesLoadWithOverviewMode)
FrameTestHelpers::WebViewHelper webViewHelper;
webViewHelper.initializeAndLoad(m_baseURL + "viewport-wide-2x-initial-scale.html", true, 0, &client, enableViewportSettings);
- webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);
+ webViewHelper.webView()->settings()->setShrinksViewportContentToFit(false);
webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
// The page must be displayed at 200% zoom, as specified in its viewport meta tag.
@@ -1227,7 +1227,7 @@ TEST_F(WebFrameTest, setInitialPageScaleFactorPermanently)
webViewHelper.initializeAndLoad(m_baseURL + "fixed_layout.html", true, 0, &client, enableViewportSettings);
applyViewportStyleOverride(&webViewHelper);
webViewHelper.webView()->settings()->setWideViewportQuirkEnabled(true);
- webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);
+ webViewHelper.webView()->settings()->setShrinksViewportContentToFit(false);
webViewHelper.webView()->setInitialPageScaleOverride(enforcedPageScaleFactor);
webViewHelper.webView()->layout();
@@ -1245,7 +1245,7 @@ TEST_F(WebFrameTest, setInitialPageScaleFactorPermanently)
EXPECT_EQ(1.0, webViewHelper.webView()->pageScaleFactor());
}
-TEST_F(WebFrameTest, PermanentInitialPageScaleFactorOverridesLoadWithOverviewMode)
+TEST_F(WebFrameTest, PermanentInitialPageScaleFactorOverridesLoadWithShrinksViewportContentToFit)
{
UseMockScrollbarSettings mockScrollbarSettings;
registerMockedHttpURLLoad("viewport-auto-initial-scale.html");
@@ -1258,7 +1258,7 @@ TEST_F(WebFrameTest, PermanentInitialPageScaleFactorOverridesLoadWithOverviewMod
FrameTestHelpers::WebViewHelper webViewHelper;
webViewHelper.initializeAndLoad(m_baseURL + "viewport-auto-initial-scale.html", true, 0, &client, enableViewportSettings);
- webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);
+ webViewHelper.webView()->settings()->setShrinksViewportContentToFit(false);
webViewHelper.webView()->setInitialPageScaleOverride(enforcedPageScaleFactor);
webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
@@ -1334,7 +1334,7 @@ TEST_F(WebFrameTest, PermanentInitialPageScaleFactorAffectsLayoutWidth)
webViewHelper.initializeAndLoad("about:blank", true, 0, &client, enableViewportSettings);
webViewHelper.webView()->settings()->setWideViewportQuirkEnabled(true);
webViewHelper.webView()->settings()->setUseWideViewport(false);
- webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);
+ webViewHelper.webView()->settings()->setShrinksViewportContentToFit(false);
webViewHelper.webView()->setInitialPageScaleOverride(enforcedPageScaleFactor);
webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698