Issue 344183006: Remove references to pepperversion and peppernum for NaCl docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344183006: Remove references to pepperversion and peppernum for NaCl docs. (Closed)

Created:
6 years, 6 months ago by binji

Modified:
6 years, 6 months ago

Reviewers:
Sam Clegg, not at google - send to devlin

CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove references to pepperversion and peppernum for NaCl docs. BUG=none R=kalman@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278862

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	chrome/common/extensions/docs/server2/template_renderer.py	View		1 chunk	+0 lines, -4 lines	1 comment	Download
	M	native_client_sdk/doc_generated/community/application-gallery.html	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

binji

https://codereview.chromium.org/344183006/diff/1/chrome/common/extensions/docs/server2/template_renderer.py File chrome/common/extensions/docs/server2/template_renderer.py (left): https://codereview.chromium.org/344183006/diff/1/chrome/common/extensions/docs/server2/template_renderer.py#oldcode42 chrome/common/extensions/docs/server2/template_renderer.py:42: 'pepperversion': '', This used to be in the pepper ...

6 years, 6 months ago (2014-06-20 23:24:07 UTC) #2

not at google - send to devlin

p.s. if the presubmit warning tells you to bump app/cron.yaml you can ignore it.

6 years, 6 months ago (2014-06-20 23:24:19 UTC) #3

binji

6 years, 6 months ago (2014-06-20 23:37:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r278862 (presubmit successful).

Expand Messages | Collapse Messages