Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 344163002: Rearrange the extensions API GYP file to be readable by GN. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rearrange the extensions API GYP file to be readable by GN. There should be no behavior change. R=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -134 lines) Patch
M chrome/common/extensions/api/api.gyp View 2 chunks +182 lines, -134 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 6 months ago (2014-06-20 06:38:07 UTC) #1
miket_OOO
Rubber-stamp LGTM
6 years, 6 months ago (2014-06-20 15:58:46 UTC) #2
brettw
6 years, 6 months ago (2014-06-20 17:05:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r278729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698