Pickle::Write* micro-optimizations

ipc/ipc_message_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message_utils.h"
 
 #include "base/files/file_path.h"
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/nullable_string16.h"
@@ skipping 293 matching lines @@
 }
 
 void ParamTraits<long long>::Log(const param_type& p, std::string* l) {
   l->append(base::Int64ToString(static_cast<int64>(p)));
 }
 
 void ParamTraits<unsigned long long>::Log(const param_type& p, std::string* l) {
   l->append(base::Uint64ToString(p));
 }
 
-void ParamTraits<float>::Write(Message* m, const param_type& p) {
-  m->WriteData(reinterpret_cast<const char*>(&p), sizeof(param_type));
-}
-
 bool ParamTraits<float>::Read(const Message* m, PickleIterator* iter,
                               param_type* r) {
-  const char *data;
-  int data_size;
-  if (!m->ReadData(iter, &data, &data_size) ||
-      data_size != sizeof(param_type)) {
+  if (!m->ReadFloat(iter, r)) {
     NOTREACHED();
     return false;
   }
-  memcpy(r, data, sizeof(param_type));
   return true;
 }
 
 void ParamTraits<float>::Log(const param_type& p, std::string* l) {
   l->append(base::StringPrintf("%e", p));
 }
 
 void ParamTraits<double>::Write(Message* m, const param_type& p) {
   m->WriteData(reinterpret_cast<const char*>(&p), sizeof(param_type));

[danakj, 2013/10/22 17:22:05]

This is funny too, should be WriteBytes

[piman, 2013/10/24 06:17:14]

Done, though I extracted this part to a separate CL -
https://codereview.chromium.org/39363002/

 }
 
 bool ParamTraits<double>::Read(const Message* m, PickleIterator* iter,
                                param_type* r) {
   const char *data;
   int data_size;
   if (!m->ReadData(iter, &data, &data_size) ||
       data_size != sizeof(param_type)) {
     NOTREACHED();
     return false;
@@ skipping 495 matching lines @@
   return result;
 }
 
 void ParamTraits<MSG>::Log(const param_type& p, std::string* l) {
   l->append("<MSG>");
 }
 
 #endif  // OS_WIN
 
 }  // namespace IPC