Pickle::Write* micro-optimizations

content/common/cc_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/cc_messages.h"
 
 #include "base/command_line.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/filter_operations.h"
 #include "content/public/common/common_param_traits.h"
@@ skipping 337 matching lines @@
 void ParamTraits<cc::RenderPass>::Write(
     Message* m, const param_type& p) {
   WriteParam(m, p.id);
   WriteParam(m, p.output_rect);
   WriteParam(m, p.damage_rect);
   WriteParam(m, p.transform_to_root_target);
   WriteParam(m, p.has_transparent_background);
   WriteParam(m, p.shared_quad_state_list.size());
   WriteParam(m, p.quad_list.size());
 
+  m->Reserve(p.shared_quad_state_list.size() * sizeof(cc::SharedQuadState) + p.quad_list.size() * sizeof(cc::RenderPassDrawQuad));

[danakj, 2013/10/22 17:22:05]

We could walk the quad list and determine the size to reserve, wdyt?

+
   for (size_t i = 0; i < p.shared_quad_state_list.size(); ++i)
     WriteParam(m, *p.shared_quad_state_list[i]);
 
   size_t shared_quad_state_index = 0;
   for (size_t i = 0; i < p.quad_list.size(); ++i) {
     const cc::DrawQuad* quad = p.quad_list[i];
     DCHECK(quad->rect.Contains(quad->visible_rect))
         << quad->material << " rect: " << quad->rect.ToString()
         << " visible_rect: " << quad->visible_rect.ToString();
     DCHECK(quad->opaque_rect.IsEmpty() ||
@@ skipping 409 matching lines @@
   l->append(", [");
   for (size_t i = 0; i < p.render_pass_list.size(); ++i) {
     if (i)
       l->append(", ");
     LogParam(*p.render_pass_list[i], l);
   }
   l->append("])");
 }
 
 }  // namespace IPC