Issue 3441033: GTTF: clean up http server launching in ui_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3441033: GTTF: clean up http server launching in ui_tests. (Closed)

Created:
10 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
huanr, nsylvain, Evan Martin

CC:
chromium-reviews, Paweł Hajdan Jr.

Visibility:
Public.

GTTF: clean up http server launching in ui_tests. We can use the utilities from base/process_util. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60786

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -28 lines)			Patch
	M	chrome/test/ui/ui_test.cc	View	1	2 chunks	+20 lines, -28 lines	0 comments	Download

Total messages: 4 (0 generated)

Evan Martin

I don't want to review thsi because I don't know the windows subtleties. Maybe nsylvain ...

10 years, 2 months ago (2010-09-27 16:15:57 UTC) #2

LGTM