Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 344103002: Fix arrow position in action-style comboboxes on Linux in GTK theme mode. (Closed)

Created:
6 years, 6 months ago by Evan Stade
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Fix arrow position in action-style comboboxes on Linux in GTK theme mode. BUG=386487 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278685

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M ui/views/controls/combobox/combobox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 5 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
6 years, 6 months ago (2014-06-19 21:54:51 UTC) #1
sky
Ugh, LGTM
6 years, 6 months ago (2014-06-19 23:16:48 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-06-19 23:44:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/344103002/20001
6 years, 6 months ago (2014-06-19 23:45:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 07:54:02 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 12:55:26 UTC) #6
Message was sent while issue was closed.
Change committed as 278685

Powered by Google App Engine
This is Rietveld 408576698